Skip to content

Commit c8ddaba

Browse files
committed
test: Address SonarQube findings on RequestTest and RequestContextTest
- Use Request::bytes method reference instead of () -> Request.bytes() in assertThrows. - Chain assertj assertions: isEqualTo(b).hasSameHashCodeAs(b), isNotEqualTo(null).isNotEqualTo("not a context").
1 parent 69c176c commit c8ddaba

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

src/test/java/com/retailsvc/http/RequestTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,6 @@ void readsBoundContext() throws Exception {
3939

4040
@Test
4141
void readingOutsideScopeThrows() {
42-
assertThrows(NoSuchElementException.class, () -> Request.bytes());
42+
assertThrows(NoSuchElementException.class, Request::bytes);
4343
}
4444
}

src/test/java/com/retailsvc/http/internal/RequestContextTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ void equalsIsReflexive() {
2525
void equalsTreatsByteArraysStructurally() {
2626
RequestContext a = context(BODY_A, "p", "op", Map.of("k", "v"));
2727
RequestContext b = context(BODY_A_COPY, "p", "op", Map.of("k", "v"));
28-
assertThat(a).isEqualTo(b);
29-
assertThat(a).hasSameHashCodeAs(b);
28+
assertThat(a).isEqualTo(b).hasSameHashCodeAs(b);
3029
}
3130

3231
@Test
@@ -60,8 +59,7 @@ void equalsRejectsDifferentPathParameters() {
6059
@Test
6160
void equalsRejectsNullAndOtherTypes() {
6261
RequestContext c = context(BODY_A, "p", "op", Map.of());
63-
assertThat(c).isNotEqualTo(null);
64-
assertThat(c).isNotEqualTo("not a context");
62+
assertThat(c).isNotEqualTo(null).isNotEqualTo("not a context");
6563
}
6664

6765
@Test

0 commit comments

Comments
 (0)