Skip to content

Commit cdac095

Browse files
committed
fix: Drop redundant 'var' from unnamed pattern variables in DefaultValidator
Sonar java:S7475 flags 'var _' inside record patterns: when the binding is the unnamed pattern '_', the type witness is meaningless and should be omitted. Strip 'var' from the seven destructured record patterns in the schema dispatch switch.
1 parent e41d0d7 commit cdac095

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/main/java/com/retailsvc/http/validate/DefaultValidator.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,24 +127,24 @@ Optional<ValidationError> check(Object value, Schema schema, String pointer) {
127127
}
128128

129129
return switch (schema) {
130-
case RefSchema(String ref, var _) -> check(value, refResolver.apply(ref), pointer);
130+
case RefSchema(String ref, _) -> check(value, refResolver.apply(ref), pointer);
131131
case BooleanSchema _ -> checkBoolean(value, pointer);
132132
case NullSchema _ -> value == null ? OK : err(pointer, "type", "expected null", value);
133133
case StringSchema s -> checkString(value, s, pointer);
134134
case IntegerSchema i -> checkInteger(value, i, pointer);
135135
case NumberSchema n -> checkNumber(value, n, pointer);
136136
case ObjectSchema o -> checkObject(value, o, pointer);
137137
case ArraySchema a -> checkArray(value, a, pointer);
138-
case EnumSchema(List<Object> values, var _) ->
138+
case EnumSchema(List<Object> values, _) ->
139139
values.contains(value) ? OK : err(pointer, "enum", "value not in enum", value);
140-
case ConstSchema(Object expected, var _) ->
140+
case ConstSchema(Object expected, _) ->
141141
Objects.equals(expected, value)
142142
? OK
143143
: err(pointer, "const", "value does not equal const", value);
144-
case AllOfSchema(List<Schema> parts, var _) -> checkAllOf(value, parts, pointer);
145-
case AnyOfSchema(List<Schema> options, var _) -> checkAnyOf(value, options, pointer);
146-
case OneOfSchema(List<Schema> options, var _) -> checkOneOf(value, options, pointer);
147-
case NotSchema(Schema inner, var _) -> checkNot(value, inner, pointer);
144+
case AllOfSchema(List<Schema> parts, _) -> checkAllOf(value, parts, pointer);
145+
case AnyOfSchema(List<Schema> options, _) -> checkAnyOf(value, options, pointer);
146+
case OneOfSchema(List<Schema> options, _) -> checkOneOf(value, options, pointer);
147+
case NotSchema(Schema inner, _) -> checkNot(value, inner, pointer);
148148
case AlwaysSchema _ -> OK;
149149
case NeverSchema _ -> err(pointer, "false", "schema rejects all values", value);
150150
};

0 commit comments

Comments
 (0)