Commit d353b23
fix: Address code review for schema-booleans parser
- Align NeverSchema validator stub with the spec: keyword is now "false"
and the rejected value is passed through via fail() instead of require()
- Drop residual Map cast in parseAdditionalProperties; parse(value) accepts
Object directly so no unchecked cast is needed
- Static-import assertThatThrownBy in SchemaParserTest for consistency
with the existing assertThat static import
- Add parsesArrayWithBooleanFalseItems test covering items: false -> NeverSchema
- Add rejectsNullRawSchema test covering null raw input -> IllegalArgumentException
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 798598c commit d353b23
3 files changed
Lines changed: 18 additions & 3 deletions
File tree
- src
- main/java/com/retailsvc/http
- spec/schema
- validate
- test/java/com/retailsvc/http/spec/schema
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
| 142 | + | |
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
159 | 160 | | |
160 | 161 | | |
161 | 162 | | |
162 | | - | |
| 163 | + | |
163 | 164 | | |
164 | 165 | | |
165 | 166 | | |
| |||
181 | 182 | | |
182 | 183 | | |
183 | 184 | | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
184 | 199 | | |
0 commit comments