fix(test): Hoist schema construction out of assertThatThrownBy lambdas

Sonar java:S5778 wants exactly one possibly-throwing invocation inside
the lambda passed to assertThatThrownBy, so it can attribute the thrown
exception unambiguously. Extract the schema constructor (or helper call)
to a local before the assertion.

Affects 7 occurrences across DefaultValidatorDispatchTest and
ValidatorNoThrowOnHappyPathTest.

Author: thced

src/test/java/com/retailsvc/http/validate/DefaultValidatorDispatchTest.java

@@ -144,15 +144,17 @@ void allOfWithEmptyPartsAlwaysPasses() {
 
   @Test
   void anyOfWithEmptyOptionsAlwaysFails() {
-    assertThatThrownBy(() -> v.validate("anything", new AnyOfSchema(List.of(), Map.of()), "/v"))
+    var schema = new AnyOfSchema(List.of(), Map.of());
+    assertThatThrownBy(() -> v.validate("anything", schema, "/v"))
         .isInstanceOf(ValidationException.class)
         .extracting(t -> ((ValidationException) t).error().keyword())
         .isEqualTo("anyOf");
   }
 
   @Test
   void oneOfWithEmptyOptionsAlwaysFails() {
-    assertThatThrownBy(() -> v.validate("anything", new OneOfSchema(List.of(), Map.of()), "/v"))
+    var schema = new OneOfSchema(List.of(), Map.of());
+    assertThatThrownBy(() -> v.validate("anything", schema, "/v"))
         .isInstanceOf(ValidationException.class)
         .satisfies(
             t -> {
@@ -165,8 +167,8 @@ void oneOfWithEmptyOptionsAlwaysFails() {
   @Test
   void notWithNullSchemaRejectsNull() {
     // not(NullSchema) — inner accepts null, outer must reject.
-    assertThatThrownBy(
-            () -> v.validate(null, new NotSchema(new NullSchema(Map.of()), Map.of()), "/v"))
+    var schema = new NotSchema(new NullSchema(Map.of()), Map.of());
+    assertThatThrownBy(() -> v.validate(null, schema, "/v"))
         .isInstanceOf(ValidationException.class)
         .extracting(t -> ((ValidationException) t).error().keyword())
         .isEqualTo("not");
@@ -202,7 +204,8 @@ void alwaysSchemaAcceptsNull() {
 
   @Test
   void neverSchemaRejectsString() {
-    assertThatThrownBy(() -> v.validate("anything", new NeverSchema(Map.of()), "/v"))
+    var schema = new NeverSchema(Map.of());
+    assertThatThrownBy(() -> v.validate("anything", schema, "/v"))
         .isInstanceOf(ValidationException.class)
         .satisfies(
             t -> {
@@ -217,15 +220,17 @@ void neverSchemaRejectsString() {
   // Full ValidationError surface is verified by neverSchemaRejectsString; these cover keyword only.
   @Test
   void neverSchemaRejectsInteger() {
-    assertThatThrownBy(() -> v.validate(42, new NeverSchema(Map.of()), "/v"))
+    var schema = new NeverSchema(Map.of());
+    assertThatThrownBy(() -> v.validate(42, schema, "/v"))
         .isInstanceOf(ValidationException.class)
         .extracting(t -> ((ValidationException) t).error().keyword())
         .isEqualTo("false");
   }
 
   @Test
   void neverSchemaRejectsNull() {
-    assertThatThrownBy(() -> v.validate(null, new NeverSchema(Map.of()), "/v"))
+    var schema = new NeverSchema(Map.of());
+    assertThatThrownBy(() -> v.validate(null, schema, "/v"))
         .isInstanceOf(ValidationException.class)
         .extracting(t -> ((ValidationException) t).error().keyword())
         .isEqualTo("false");

src/test/java/com/retailsvc/http/validate/ValidatorNoThrowOnHappyPathTest.java

@@ -88,8 +88,9 @@ void successfulAnyOfDoesNotConstructValidationException() {
   @Test
   void failingOneOfConstructsExactlyOneValidationException() {
     long before = ValidationException.CONSTRUCTIONS.get();
+    var schema = stringOrNumber();
 
-    assertThatThrownBy(() -> validator.validate(true, stringOrNumber(), "/v"))
+    assertThatThrownBy(() -> validator.validate(true, schema, "/v"))
         .isInstanceOf(ValidationException.class)
         .extracting(t -> ((ValidationException) t).error().keyword())
         .isEqualTo("oneOf");