From 19aab25616e274d327f93b34131badc0b7c78ecb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20V=C3=A1squez?= Date: Fri, 10 Jul 2026 08:33:25 -0600 Subject: [PATCH] Update wicked_pdf 1.4.0 -> 2.8.2 (hold wkhtmltopdf-binary at 0.12.3.1) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit wicked_pdf was exact-pinned at 1.4.0 (2019); bump the maintained Ruby gem to 2.8.2. The render pdf: usage and wicked_pdf_stylesheet_link_tag / wicked_pdf_image_tag helpers are unchanged in 2.x; no initializer to migrate. wkhtmltopdf-binary is deliberately HELD at 0.12.3.1. Bumping it to 0.12.6.10 segfaulted (SIGSEGV) in the Linux runtime (CI, and by extension Heroku), and wkhtmltopdf 0.12.6 also blocks local file access by default (breaking the PDF logo/stylesheet). wkhtmltopdf is EOL, so 0.12.3.1 — the binary production already runs — stays. Used --conservative; rack stays at 2.x. Both lockfiles updated. Verified locally: PDF controller test green, full suite 16/52/0, rubocop + reek clean, and a live server upload -> PDF download returns a valid %PDF. --- Gemfile | 5 ++++- Gemfile.lock | 5 +++-- Gemfile.next.lock | 5 +++-- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/Gemfile b/Gemfile index 3b117bb..35bd6cc 100644 --- a/Gemfile +++ b/Gemfile @@ -40,7 +40,10 @@ gem "sass-rails", "~> 6.0" gem "terser" gem "redcarpet" -gem "wicked_pdf", "1.4.0" +gem "wicked_pdf", "~> 2.8" +# wkhtmltopdf-binary is held at 0.12.3.1: the 0.12.6.x Linux binary segfaults +# (SIGSEGV) in CI/Heroku, and 0.12.6 also blocks local file access by default, +# which breaks the PDF's logo/stylesheet. wkhtmltopdf is EOL, so 0.12.3.1 stays. gem "wkhtmltopdf-binary", "0.12.3.1" gem "fastruby-styleguide", git: "https://github.com/fastruby/styleguide.git", branch: "gh-pages" diff --git a/Gemfile.lock b/Gemfile.lock index 920bfb8..cd16845 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -407,8 +407,9 @@ GEM base64 websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) - wicked_pdf (1.4.0) + wicked_pdf (2.8.2) activesupport + ostruct wkhtmltopdf-binary (0.12.3.1) xpath (3.2.0) nokogiri (~> 1.8) @@ -443,7 +444,7 @@ DEPENDENCIES terser tzinfo-data web-console (>= 3.3.0) - wicked_pdf (= 1.4.0) + wicked_pdf (~> 2.8) wkhtmltopdf-binary (= 0.12.3.1) RUBY VERSION diff --git a/Gemfile.next.lock b/Gemfile.next.lock index 920bfb8..cd16845 100644 --- a/Gemfile.next.lock +++ b/Gemfile.next.lock @@ -407,8 +407,9 @@ GEM base64 websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) - wicked_pdf (1.4.0) + wicked_pdf (2.8.2) activesupport + ostruct wkhtmltopdf-binary (0.12.3.1) xpath (3.2.0) nokogiri (~> 1.8) @@ -443,7 +444,7 @@ DEPENDENCIES terser tzinfo-data web-console (>= 3.3.0) - wicked_pdf (= 1.4.0) + wicked_pdf (~> 2.8) wkhtmltopdf-binary (= 0.12.3.1) RUBY VERSION