Skip to content

backport: remove all custom class instantiation of synapse-sdk classes #278

@SgtPooki

Description

@SgtPooki

we should be using the synapse instance we have, and methods we need should be exposed, or we should do what is otherwise recommended..

There may be use-cases where we might need to instantiate a custom WarmStorageService or PDPVerifier, but i'm thinking we probably shouldn't be doing this. We need to backport our usecases to synapse-sdk and make sure methods are exposed that allow us to do what we need "in the right way"

some classes we instantiate in filecoin-pin that we probably shouldn't, because there isn't a top-level API for doing what we want:

  1. new PDPVerifier
  2. new PDPServer
  3. WarmStorageService.create
  4. new SPRegistryService

NOTE: any changes here will likely require agreed-upon plans with the synapse-sdk core devs and changes to synapse-sdk

Metadata

Metadata

Assignees

No one assigned

    Labels

    team/filecoin-pin"Filecoin Pin" project is a stakeholder for this work.team/fs-wgFOC working group is a stakeholder for this work, and thus wants to track it on their project board.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions