Commit e4f7f12
Update to Firebase iOS SDK 9.0.0 with necessary changes for Swift support and Firestore (#915)
* Remove the patch to enable Snappy support
* firestore_patch.py: also copy the URL_HASH
* query_main.h: fix build error due to Filter being renamed to FieldFilter.
* user_data_converter_main.cc: fix build error when calling NullValue(), which now just returns a google_firestore_v1_Value instead of a Message<google_firestore_v1_Value>
* Merge in #896 (leveldb_snappy_test.cc: run the test on iOS as well, and other improvements)
* leveldb_snappy_test.cc: re-use the test from the iOS SDK instead of re-writing it.
* leveldb_snappy_test.cc: add a newline at the end of the file.
* query_main.h: add missing #include "Firestore/core/src/core/field_filter.h"
* Set the FIRESTORE_INCLUDE_OBJC cmake cache var to NO to avoid building Objective-C parts of the iOS SDK
This fixes the following build error:
```
FIRFirestore.h:147:20: error: unknown attribute 'swift_async' ignored [-Werror,-Wunknown-attributes]
__attribute__((swift_async(none))); // Disable async import due to #9426.
^
1 error generated.
```
which was introduced by firebase/firebase-ios-sdk#9502
* external/pip_requirements.txt: add six
This is an attempt to fix the following build error:
```
Traceback (most recent call last):
File "Firestore/Protos/tmphmjWeu.py", line 25, in <module>
import nanopb_generator as nanopb
File "nanopb/generator/nanopb_generator.py", line 25, in <module>
import google.protobuf.text_format as text_format
File "protobuf/python/google/protobuf/text_format.py", line 51, in <module>
import six
ImportError: No module named six
```
e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6034310890
* Improve FIREBASE_PYTHON_EXECUTABLE cmake cache var and make its usage ubiquitous
* firestore.cmake: bump pinned commit
* Revert "external/pip_requirements.txt: add six" since it didn't fix the problem.
This reverts commit 56553d9.
* firestore.cmake: fix pinned commit
* Revert "Improve FIREBASE_PYTHON_EXECUTABLE cmake cache var and make its usage ubiquitous"
It seemed to cause problems with the build. There is a better way in the iOS SDK anyways.
This reverts commit c6346fd.
* firestore.cmake: update pinned commit
* CMakeLists.txt: Set FIRESTORE_INCLUDE_OBJC as a cache variable so it actually works
* query_main.cc: IsBefore(BoundPosition) -> IsInclusive(BoundPosition)
This fixes several test failures due to incorrect handling of startAfter and endBefore resulting from a change in core::Bound from "before" to "inclusive" in firebase/firebase-ios-sdk#9519
Namely, this fixes the following failure:
```
cursor_test.cc:250: Failure
Expected equality of these values:
std::vector<std::string>({"c", "f", "b", "e"})
Which is: { "c", "f", "b", "e" }
QuerySnapshotToIds(snapshot)
Which is: { "c", "f" }
[ FAILED ] FirestoreIntegrationTest.TimestampsCanBePassedToQueriesAsLimits
```
e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6044737005
* firestore.cmake: update pinned commit
* Use staging repo and update to 9.0 podfiles.
Add Swift headers from 9.0.0 zip release.
* Remove streaming support, as it fails with the new Swift SDK.
* Enable Firestore and Admob.
* Remove AdMob for now - it's broken in 7.69.0-cppsdk.
* Don't process swift headers if already processed
* fix nightly version tag
* Fix update dependencies script
* Support directories with spaces
* Exclude swift headers from linter.
* Fix whitespace
* Fix comma
* Fix whitespace.
* Fix Firestore external file.
* Restore new external file and fix include path.
* Fix include files and paths to be compatible with C++ build.
* Format code.
* Add NOLINT
* Remove included test with bad include path.
* Fix internal test podfile
* Fix podfiles
* Revert some junk that got pulled in when #898 was merged into this branch
* Temporarily remove admob from integration_tests.yml too.
* integration_tests.yml: remove admob from another place, since it still seems to be being built
* Revert "integration_tests.yml: remove admob from another place, since it still seems to be being built"
This reverts commit fc6b845.
* Revert "Temporarily remove admob from integration_tests.yml too."
This reverts commit 32aec7e.
* Add AdMob back in and refer to new version in staging.
* Speed up update-dependencies zip distribution usage
* Fix substitution.
* Fix header formatting
* Fix spacing.
* Update Xcode version to 12.5.1 and add tests to 13.2.1
* Add new version to readme
* Change Functions iOS SDK and tvOS SDK version to 12.4 (minimum for Swift).
* Since FIRStorageMetadata no longer implements NSCopying, copy it a different way.
* Change deployment version to 12.4 for Storage, required for Swift support.
* Update analytics headers from 9.0.0 Analytics RC.
* Add note about removal of deprecated analytics constants.
* Set analytics deployment target
* Set deployment targets
* Add empty Swift file to sample framework.
* Switch Podfile postprocessing to use python3
* Add empty Swift file to integration test project.
* Add empty Swift file to analytics project
* Add empty.swift to remaining integration test projects.
* Check to make sure that the controller can pause/resume/etc.
* Workaround for pause/cancel/resume semantics changing in 9.x.
* Switch from nightly to release tag for Firestore external dep.
* Update Xcode version to 13.2.1, required version for iOS SDK.
* Change deployment target back to 10.x.
* Fix iOS deployment version back to 10.0
* Add notes about including a swift file
* Change comparison to lower-case to prevent restore_secrets overriding it.
* Clean up the verbose log of file size
* firestore_snappy.patch.txt: remove the patching for firebase/firebase-ios-sdk#9662 (Create individual Python virtualenv's in cmake builds) since it's incorporated into the CocoaPods-9.0.0.nightly tag
* CHERRY PICK from main branch: leveldb_snappy_test.cc: run the test on iOS as well, and other improvements (#896)
This change improves the leveldb_snappy_test.cc to provide stronger guarantees of expected behavior.
* Set block storage for task variable.
* Fix server key.
* Format code.
* test iOS simulator devices
* Windows compatibility for strcasecmp
* test iOS simulator devices
* Update Swift header to include copy method; revert Storage to use it.
* upload ios projects artifacts
* Temporarily disable a test that fails on device when built from cmdline.
* Update the testing Xcode version to 13.3.1
* Change xcode version to 13.3.1 and macos runners to macos-12.
* Restore simulator versions back to previous values
* Reworded some release notes.
(Also replaced a couple tabs with spaces.)
* Revert "upload ios projects artifacts"
This reverts commit e04d6a6.
* Fix Swift header script to work with multiple URLs.
* Update Swift headers for final 9.0.0 release
* Add readme about ios_pod directory and its swift_headers subdirectory
* Remove staging repo from podfiles. (#923)
* If the zip file can't be downloaded, just skip that step.
Co-authored-by: Denver Coneybeare <dconeybe@google.com>
Co-authored-by: Mou <sunmou@google.com>
Co-authored-by: Mou Sun <69009538+sunmou99@users.noreply.github.com>
Co-authored-by: a-maurice <amaurice@google.com>1 parent 266456e commit e4f7f12
File tree
75 files changed
+3953
-857
lines changed- .github/workflows
- admob/integration_test
- integration_test.xcodeproj
- analytics
- integration_test
- integration_test.xcodeproj
- ios_headers
- app/integration_test
- integration_test.xcodeproj
- auth/integration_test
- integration_test.xcodeproj
- cmake/external
- database/integration_test
- integration_test.xcodeproj
- dynamic_links/integration_test
- integration_test.xcodeproj
- firestore
- integration_test_internal
- integration_test.xcodeproj
- integration_test
- integration_test.xcodeproj
- src/main
- functions
- integration_test
- integration_test.xcodeproj
- src/ios
- installations/integration_test
- integration_test.xcodeproj
- ios_pod
- swift_headers
- messaging/integration_test
- integration_test.xcodeproj
- src
- release_build_files
- remote_config/integration_test
- integration_test.xcodeproj
- scripts/gha
- storage
- integration_test
- integration_test.xcodeproj
- src
- src/ios
- testing/sample_framework/src
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
75 files changed
+3953
-857
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
125 | 156 | | |
126 | 157 | | |
127 | 158 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| 38 | + | |
37 | 39 | | |
38 | 40 | | |
39 | 41 | | |
| |||
94 | 96 | | |
95 | 97 | | |
96 | 98 | | |
| 99 | + | |
97 | 100 | | |
98 | 101 | | |
99 | 102 | | |
| |||
149 | 152 | | |
150 | 153 | | |
151 | 154 | | |
| 155 | + | |
152 | 156 | | |
153 | 157 | | |
154 | 158 | | |
| |||
158 | 162 | | |
159 | 163 | | |
160 | 164 | | |
| 165 | + | |
161 | 166 | | |
162 | 167 | | |
163 | 168 | | |
| |||
193 | 198 | | |
194 | 199 | | |
195 | 200 | | |
| 201 | + | |
196 | 202 | | |
197 | 203 | | |
198 | 204 | | |
| |||
286 | 292 | | |
287 | 293 | | |
288 | 294 | | |
| 295 | + | |
289 | 296 | | |
290 | 297 | | |
291 | 298 | | |
| |||
303 | 310 | | |
304 | 311 | | |
305 | 312 | | |
| 313 | + | |
306 | 314 | | |
307 | 315 | | |
| 316 | + | |
| 317 | + | |
308 | 318 | | |
309 | 319 | | |
310 | 320 | | |
| |||
314 | 324 | | |
315 | 325 | | |
316 | 326 | | |
| 327 | + | |
317 | 328 | | |
318 | 329 | | |
319 | 330 | | |
| |||
331 | 342 | | |
332 | 343 | | |
333 | 344 | | |
| 345 | + | |
334 | 346 | | |
335 | 347 | | |
| 348 | + | |
336 | 349 | | |
337 | 350 | | |
338 | 351 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
| 18 | + | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
Lines changed: 20 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| |||
56 | 58 | | |
57 | 59 | | |
58 | 60 | | |
| 61 | + | |
59 | 62 | | |
60 | 63 | | |
61 | 64 | | |
| |||
132 | 135 | | |
133 | 136 | | |
134 | 137 | | |
| 138 | + | |
135 | 139 | | |
136 | 140 | | |
137 | 141 | | |
| |||
215 | 219 | | |
216 | 220 | | |
217 | 221 | | |
| 222 | + | |
218 | 223 | | |
219 | 224 | | |
220 | 225 | | |
221 | 226 | | |
| 227 | + | |
222 | 228 | | |
223 | 229 | | |
224 | 230 | | |
| |||
323 | 329 | | |
324 | 330 | | |
325 | 331 | | |
| 332 | + | |
326 | 333 | | |
327 | 334 | | |
328 | 335 | | |
| |||
337 | 344 | | |
338 | 345 | | |
339 | 346 | | |
| 347 | + | |
340 | 348 | | |
341 | 349 | | |
342 | 350 | | |
| |||
449 | 457 | | |
450 | 458 | | |
451 | 459 | | |
| 460 | + | |
452 | 461 | | |
453 | 462 | | |
454 | 463 | | |
| |||
466 | 475 | | |
467 | 476 | | |
468 | 477 | | |
| 478 | + | |
469 | 479 | | |
470 | 480 | | |
| 481 | + | |
| 482 | + | |
471 | 483 | | |
472 | 484 | | |
473 | 485 | | |
| |||
477 | 489 | | |
478 | 490 | | |
479 | 491 | | |
| 492 | + | |
480 | 493 | | |
481 | 494 | | |
482 | 495 | | |
| |||
494 | 507 | | |
495 | 508 | | |
496 | 509 | | |
| 510 | + | |
497 | 511 | | |
498 | 512 | | |
| 513 | + | |
499 | 514 | | |
500 | 515 | | |
501 | 516 | | |
| |||
508 | 523 | | |
509 | 524 | | |
510 | 525 | | |
| 526 | + | |
511 | 527 | | |
512 | 528 | | |
513 | 529 | | |
| |||
546 | 562 | | |
547 | 563 | | |
548 | 564 | | |
| 565 | + | |
| 566 | + | |
549 | 567 | | |
550 | 568 | | |
551 | 569 | | |
| |||
559 | 577 | | |
560 | 578 | | |
561 | 579 | | |
| 580 | + | |
562 | 581 | | |
563 | 582 | | |
564 | 583 | | |
| |||
595 | 614 | | |
596 | 615 | | |
597 | 616 | | |
| 617 | + | |
598 | 618 | | |
599 | 619 | | |
600 | 620 | | |
| |||
0 commit comments