feat(collector): make blob (type-3) sidecar requirement opt-in#88
Open
curcio wants to merge 3 commits into
Open
feat(collector): make blob (type-3) sidecar requirement opt-in#88curcio wants to merge 3 commits into
curcio wants to merge 3 commits into
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This pull request introduces a new configuration option to control the handling of EIP-4844 (type-3) transactions with missing blob sidecars. By default, the collector is now permissive and accepts canonical-only blob transactions, but a new flag allows restoring the previous strict validation behavior. The main changes are as follows:
Configuration and CLI changes:
require-blob-sidecar(and corresponding environment variable) to enable strict validation for blob transactions, rejecting those without a sidecar. This restores pre-v1.4 behavior when enabled. (cmd/collect/main.go)require-blob-sidecarflag through the collector and transaction processor configuration structs. (cmd/collect/main.go,collector/collector.go,collector/tx_processor.go) [1] [2] [3] [4] [5] [6] [7]Transaction validation logic:
validateBlobTxso that, by default, blob transactions without a sidecar are accepted, and strict rejection only occurs ifrequireBlobSidecaris set. (collector/tx_processor.go) [1] [2]⛱ Motivation and Context
The collector's validateBlobTx rejects every EIP-4844 (type-3) transaction whose BlobTxSidecar() is nil, routing it to the trash file. In practice, this drops all blob transactions when the collector is fed by a standard Execution-Layer JSON-RPC subscription (eth_subscribe("newPendingTransactions") on geth / reth, and most public mempool feed providers).
The user-visible effect is that for collectors using JSON-RPC sources (i.e., most setups), the transactions output / ClickHouse table contains no type-3 rows at all, even though sourcelogs and other hash-level outputs do see them.
📚 References
✅ I have run these commands
make lintmake testgo mod tidy