refactor(config): [rules] error on missing leading blank lines

Signed-off-by: Lexus Drumgold <unicornware@flexdevelopment.llc>

Author: unicornware

src/config/__snapshots__/rules.integration.snap

@@ -11,21 +11,21 @@ exports[`integration:config/rules > @commitlint/lint > body-full-stop > should e
 ]
 `;
 
-exports[`integration:config/rules > @commitlint/lint > body-leading-blank > should warn if body does not have leading blank line 1`] = `
+exports[`integration:config/rules > @commitlint/lint > body-leading-blank > should error if body comes after 1 new line 1`] = `
 [
   {
-    "level": 1,
+    "level": 2,
     "message": "body must have leading blank line",
     "name": "body-leading-blank",
     "valid": false,
   },
 ]
 `;
 
-exports[`integration:config/rules > @commitlint/lint > footer-leading-blank > should warn if footer does not have leading blank line 1`] = `
+exports[`integration:config/rules > @commitlint/lint > footer-leading-blank > should error if footer comes after 1 new line 1`] = `
 [
   {
-    "level": 1,
+    "level": 2,
     "message": "footer must have leading blank line",
     "name": "footer-leading-blank",
     "valid": false,

src/config/__tests__/rules.integration.spec.ts

@@ -73,17 +73,17 @@ describe('integration:config/rules', () => {
 
       beforeAll(() => {
         rule = 'body-leading-blank'
-        severity = Severity.Warning
+        severity = Severity.Error
       })
 
-      it('should warn if body does not have leading blank line', async () => {
+      it('should error if body comes after 1 new line', async () => {
         // Act
         const result = await linter(signoff('fix: some message\nbody'))
 
         // Expect
-        expect(result.errors).to.be.an('array').that.is.empty
-        expect(result.warnings).to.have.ruleOutcome(rule, severity)
-        expect(result.warnings).toMatchSnapshot()
+        expect(result.errors).to.have.ruleOutcome(rule, severity)
+        expect(result.warnings).to.be.an('array').that.is.empty
+        expect(result.errors).toMatchSnapshot()
       })
     })
 
@@ -139,10 +139,10 @@ describe('integration:config/rules', () => {
 
       beforeAll(() => {
         rule = 'footer-leading-blank'
-        severity = Severity.Warning
+        severity = Severity.Error
       })
 
-      it('should warn if footer does not have leading blank line', async () => {
+      it('should error if footer comes after 1 new line', async () => {
         // Arrange
         const commit: string =
           'test: some message\n\nbody\nBREAKING CHANGE: It will be significant'
@@ -151,9 +151,9 @@ describe('integration:config/rules', () => {
         const result = await linter(signoff(commit, 0))
 
         // Expect
-        expect(result.errors).to.be.an('array').that.is.empty
-        expect(result.warnings).to.have.ruleOutcome(rule, severity)
-        expect(result.warnings).toMatchSnapshot()
+        expect(result.errors).to.have.ruleOutcome(rule, severity)
+        expect(result.warnings).to.be.an('array').that.is.empty
+        expect(result.errors).toMatchSnapshot()
       })
     })
 

src/config/rules.ts

@@ -23,12 +23,12 @@ const rules: RulesConfig = {
   'body-case': [Severity.Disabled],
   'body-empty': [Severity.Disabled],
   'body-full-stop': [Severity.Error, 'never', '.'],
-  'body-leading-blank': [Severity.Warning, 'always'],
+  'body-leading-blank': [Severity.Error, 'always'],
   'body-max-length': [Severity.Error, 'always', Number.MAX_SAFE_INTEGER],
   'body-max-line-length': [Severity.Error, 'always', 2050],
   'body-min-length': [Severity.Disabled],
   'footer-empty': [Severity.Disabled],
-  'footer-leading-blank': [Severity.Warning, 'always'],
+  'footer-leading-blank': [Severity.Error, 'always'],
   'footer-max-length': [Severity.Error, 'always', Number.MAX_SAFE_INTEGER],
   'footer-max-line-length': [Severity.Error, 'always', 2050],
   'footer-min-length': [Severity.Disabled],