Hot reload fails when running as a Windows service

[williamb1024]

Bug Report

Describe the bug
When running fluent-bit as a Windows service, calls to http://localhost:2020/api/v2/reload fail with an HTTP status of 500.

To Reproduce

• Configure fluent-bit as a Windows service
• Enable HTTP server and hot reload support
• Request a reload through HTTP

Expected behavior
Fluent-bit would respond with an HTTP status 200 OK and reload its configuration.

Your Environment

• Version used: 3.2.4

• Configuration:

  service:
    http_server: true
    http_listen: 0.0.0.0
    http_port: 2020
    hot_reload: true 
  

• Operating System and version: Windows 11 24H2

• Filters and plugins: None

Additional context
This issue prevents reloading due to configuration changes. A simple workaround is the restart the fluent-bit service.

The issue appears to be:

fluent-bit/src/http_server/api/v2/reload.c

Line 70 in 417d129

ret = GenerateConsoleCtrlEvent(1 /* CTRL_BREAK_EVENT_1 */, 0);

GenerateConsoleCtrlEvent fails in the context of a Windows service. I believe, but have not tested, that the process is started in a detached console mode, which prevents GenerateConsoleCtrlEvent from succeeding.

A simple solution would be to use AllocConsole() when run as a Windows service.

[patrick-stephens]

I think this is a known issue @pwhelan already has a fix for we just need to upstream it.

[pwhelan]

I think this is a known issue @pwhelan already has a fix for we just need to upstream it.

I fixed the problem specifically for fleet but can I apply the same fix for the hotreload HTTP API. Will submit a PR once I test on windows.

** edit **

I will specifically be able to test the fix now. I should have a PR this week.

[pwhelan]

I have submitted the fix but it is in draft for the moment.

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

[pwhelan]

This work is being subsumed by #10244.

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

[github-actions]

This issue was closed because it has been stalled for 5 days with no activity.