From 6bbe8a96a1457e10856797e55627b538b7019175 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?An=C4=B1lcan=20=C3=87ak=C4=B1r?= Date: Thu, 24 Sep 2026 13:04:49 +0300 Subject: [PATCH] fix(dashboard): scroll the page itself magic_starter's app shell stops scrolling its content box (fluttersdk/magic_starter#166): a scroll around the shell's nested Navigator broke a page left under a stacked route. Under the new default a page taller than the window scrolls itself, and this one had no scroll of its own. Under the old default the inner scroll sizes to its content and claims no drag, so this lands safely either way. --- lib/resources/views/dashboard_view.dart | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/lib/resources/views/dashboard_view.dart b/lib/resources/views/dashboard_view.dart index a985272..5186e10 100644 --- a/lib/resources/views/dashboard_view.dart +++ b/lib/resources/views/dashboard_view.dart @@ -93,11 +93,18 @@ class _DashboardViewState Widget build(BuildContext context) { final appName = Config.get('app.name', 'My App') ?? 'My App'; - return WDiv( - className: 'w-full max-w-[480px] md:max-w-4xl mx-auto p-4 lg:p-8', - child: controller.renderState( - (name) => _buildLoaded(appName: appName, greetingName: name), - onLoading: _buildSkeleton(), + // Its own scroll: magic_starter's app shell stopped scrolling its content + // box (a scroll around the shell's nested Navigator broke a page left + // under a stacked route), so a page taller than the window scrolls + // itself. `primary: false`, as MSPageScaffold does. + return SingleChildScrollView( + primary: false, + child: WDiv( + className: 'w-full max-w-[480px] md:max-w-4xl mx-auto p-4 lg:p-8', + child: controller.renderState( + (name) => _buildLoaded(appName: appName, greetingName: name), + onLoading: _buildSkeleton(), + ), ), ); }