Memory leak when clicking on “Load diff” on a large diff

[robinwhittleton]

Fork got up to 82GB usage before my system came to a halt and I had to kill it. This happened after I clicked on “Load diff” for a large diff. Unfortunately the code isn’t open source so I can’t share it, but it’s a ~1MB minimised JS file all on one line (with a short comment on line 2).

I don’t expect you to do anything about this, but just for reference in case you want to investigate.

[DanPristupov]

Looking into it

[robinwhittleton]

Sorry, should have said that I’m on 2.67.1 on the develop channel. I can’t see any relevant logs in Console.

[DanPristupov]

I suspect I know the source of the issue. I improved line highlighting and now its O(n^2) complexity. While it works for average lines, it's clearly not viable for minified files.

[DanPristupov]

Done!
Can you check if the problem is fixed in https://cdn.fork.dev/mac/Fork-2.67.4.dmg?

[robinwhittleton]

Yep! Took under 2 secs to generate a diff view on this M2 macbook pro. Thanks, speedy service 😊