Skip to content

Branch not used when checking out locale #35

@tomfresen

Description

@tomfresen

Hi there, hope this project is still maintained?

I noticed I always get a 404 exception when trying to download a branch of any project, e.g.

    PhraseAppSyncTask task =
        new PhraseAppSyncTask(tok, id, Collections.singletonList("my-branch-name"), "https://api.phraseapp.com");
    task.run();

Reason is the branch parameter is never used:
https://github.com/freenowtech/phrase-java-client/blob/master/src/main/java/com/freenow/apis/phrase/api/locale/PhraseLocaleAPI.java#L92

Fix attached

Best regards
Tom

use-branch-params.patch

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions