From 2124c783855fe3c6b152d9728eb5c014ce49aa22 Mon Sep 17 00:00:00 2001 From: luo2430 Date: Thu, 2 Jul 2026 08:23:18 +0800 Subject: [PATCH] refactor(galacean): replace @ts-ignore with @ts-expect-error and modernize loop --- packages/galacean/src/ShaderPool.ts | 4 ++-- packages/galacean/src/index.ts | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/galacean/src/ShaderPool.ts b/packages/galacean/src/ShaderPool.ts index 52878d4d3f..430d9f335e 100644 --- a/packages/galacean/src/ShaderPool.ts +++ b/packages/galacean/src/ShaderPool.ts @@ -79,7 +79,7 @@ export class ShaderPool { ]; for (const source of sources) { - // @ts-ignore — `_createFromPrecompiled` is `Shader` @internal. + // @ts-expect-error — `_createFromPrecompiled` is `Shader` @internal. Shader._createFromPrecompiled(source); } @@ -87,7 +87,7 @@ export class ShaderPool { // The pass itself is later looked up via `Shader.find` inside // `ParticleTransformFeedbackSimulator`, so no caching needed here. const feedbackPass = Shader.find("Effect/ParticleFeedback").subShaders[0].passes[0]; - // @ts-ignore — `_feedbackVaryings` is `ShaderPass` @internal. + // @ts-expect-error — `_feedbackVaryings` is `ShaderPass` @internal. feedbackPass._feedbackVaryings = ["v_FeedbackPosition", "v_FeedbackVelocity"]; } } diff --git a/packages/galacean/src/index.ts b/packages/galacean/src/index.ts index de3768419f..0afb7953fa 100644 --- a/packages/galacean/src/index.ts +++ b/packages/galacean/src/index.ts @@ -1,7 +1,7 @@ import * as CoreObjects from "@galacean/engine-core"; import { Loader, Polyfill, SystemInfo } from "@galacean/engine-core"; import { ShaderPool } from "./ShaderPool"; -//@ts-ignore + export const version = `__buildVersion`; console.log(`Galacean Engine Version: ${version}`); @@ -11,8 +11,8 @@ export * from "@galacean/engine-loader"; export * from "@galacean/engine-math"; export * from "@galacean/engine-rhi-webgl"; -for (let key in CoreObjects) { - Loader.registerClass(key, CoreObjects[key]); +for (const [key, value] of Object.entries(CoreObjects)) { + Loader.registerClass(key, value); } // Bootstrap the Galacean engine flavor: browser polyfills first (must @@ -26,7 +26,7 @@ for (let key in CoreObjects) { // shader bundle dependency), which in turn lets the offline shader // compiler import core's enums without dragging the full runtime closure. Polyfill.registerPolyfill(); -// @ts-ignore — `_initialize` is `SystemInfo` @internal. +// @ts-expect-error — `_initialize` is `SystemInfo` @internal. SystemInfo._initialize(); ShaderPool.init(); ShaderPool.registerShaders();