From e7eceed402e691b20b49a35640baf4f5d8da41e7 Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Thu, 17 Sep 2026 15:15:22 +0200 Subject: [PATCH] ci: include version in the release archive name Fixes: #745 --- .craft.yml | 4 ++-- .github/workflows/ci.yml | 6 ++++-- CHANGELOG.md | 1 + 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.craft.yml b/.craft.yml index a828802521..c96434b252 100644 --- a/.craft.yml +++ b/.craft.yml @@ -8,7 +8,7 @@ targets: github:getsentry/sentry-native: maven:io.sentry:sentry-native-ndk: - name: gcs - includeNames: /^(sentry-native\.zip)$/ + includeNames: /^sentry-native-\d+\.\d+\.\d+.*\.zip$/ bucket: sentry-sdk-assets paths: - path: /sentry-native/{{version}}/ @@ -32,4 +32,4 @@ targets: batchType: android bundleIdPrefix: sentry-native-ndk- requireNames: - - /^sentry-native.zip$/ + - /^sentry-native-\d+\.\d+\.\d+.*\.zip$/ diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5ace028b9b..8c4c0fda61 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -582,8 +582,10 @@ jobs: - name: Create source archive run: | + version=$(sed -nE 's/^#[[:space:]]*define[[:space:]]+SENTRY_SDK_VERSION[[:space:]]+"([^"]+)".*/\1/p' include/sentry.h) + test -n "$version" rm -rf build .c* .e* .git* scripts Makefile external/breakpad/src/tools external/breakpad/src/processor - zip -r sentry-native.zip . + zip -r "sentry-native-$version.zip" . - name: Build NDK artifacts working-directory: ndk @@ -595,6 +597,6 @@ jobs: name: ${{ github.sha }} if-no-files-found: error path: | - sentry-native.zip + sentry-native-*.zip ndk/lib/build/distributions/*.zip ndk/lib/build/intermediates/merged_native_libs/release/mergeReleaseNativeLibs/out/lib/* diff --git a/CHANGELOG.md b/CHANGELOG.md index 416b0b9889..a85495df2a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - macOS/Linux: shared libraries now use ABI-versioned filenames, such as `libsentry.1.dylib` or `libsentry.so.1` for 1.x. Windows, Android, and static libraries remain unchanged. ([#2103](https://github.com/getsentry/sentry-native/pull/2103)) - NOTE: Applications must package the real versioned library and its symlinks, including `libsentry.1.dylib` or `libsentry.so.1`, because they link to and load the ABI-versioned name. +- Release archives now include the SDK version in the filename, such as `sentry-native-1.0.0.zip`. ([#2105](https://github.com/getsentry/sentry-native/pull/2105)) ## Unreleased