Skip to content

Commit eda0dec

Browse files
revert litestar and starlite tests as behavior unchanged
1 parent b420587 commit eda0dec

2 files changed

Lines changed: 0 additions & 96 deletions

File tree

tests/integrations/litestar/test_litestar.py

Lines changed: 0 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,6 @@ async def message_with_id() -> "dict[str, Any]":
5050
capture_message("hi")
5151
return {"status": "ok"}
5252

53-
@get("/nomessage")
54-
async def nomessage() -> "dict[str, Any]":
55-
return {"status": "ok"}
56-
5753
logging_config = LoggingConfig()
5854

5955
app = Litestar(
@@ -62,7 +58,6 @@ async def nomessage() -> "dict[str, Any]":
6258
custom_error,
6359
message,
6460
message_with_id,
65-
nomessage,
6661
MyController,
6762
],
6863
debug=debug,
@@ -826,48 +821,3 @@ async def error() -> None: ...
826821
event_exception = events[0]["exception"]["values"][0]
827822
assert event_exception["type"] == "RuntimeError"
828823
assert event_exception["value"] == "Too Hot"
829-
830-
831-
@pytest.mark.parametrize("span_streaming", [True, False])
832-
def test_request_url(sentry_init, capture_events, capture_items, span_streaming):
833-
sentry_init(
834-
traces_sample_rate=1.0,
835-
integrations=[LitestarIntegration()],
836-
send_default_pii=True,
837-
_experiments={
838-
"trace_lifecycle": "stream" if span_streaming else "static",
839-
},
840-
)
841-
842-
litestar_app = litestar_app_factory()
843-
client = TestClient(
844-
litestar_app, base_url="http://testserver.local", root_path="/root"
845-
)
846-
847-
if span_streaming:
848-
items = capture_items("span")
849-
850-
# https://github.com/litestar-org/litestar/commit/72dda171768bd470adc065c47c1ecf1d80b5e749
851-
url = "/root/nomessage" if LITESTAR_VERSION >= (2, 5, 3) else "/nomessage"
852-
client.get(url)
853-
854-
sentry_sdk.flush()
855-
spans = [item.payload for item in items]
856-
857-
(server_span,) = (
858-
span
859-
for span in spans
860-
if span["attributes"].get("sentry.op") == "http.server"
861-
)
862-
assert server_span["attributes"]["url.full"] == (
863-
"http://testserver.local/root/nomessage"
864-
)
865-
else:
866-
events = capture_events()
867-
868-
# https://github.com/litestar-org/litestar/commit/72dda171768bd470adc065c47c1ecf1d80b5e749
869-
url = "/root/nomessage" if LITESTAR_VERSION >= (2, 5, 3) else "/nomessage"
870-
client.get(url)
871-
872-
(event,) = events
873-
assert event["request"]["url"] == "http://testserver.local/root/nomessage"

tests/integrations/starlite/test_starlite.py

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ async def message_with_id() -> "Dict[str, Any]":
4141
capture_message("hi")
4242
return {"status": "ok"}
4343

44-
@get("/nomessage")
45-
async def nomessage() -> "Dict[str, Any]":
46-
return {"status": "ok"}
47-
4844
logging_config = LoggingConfig()
4945

5046
app = Starlite(
@@ -53,7 +49,6 @@ async def nomessage() -> "Dict[str, Any]":
5349
custom_error,
5450
message,
5551
message_with_id,
56-
nomessage,
5752
MyController,
5853
],
5954
debug=debug,
@@ -579,44 +574,3 @@ async def __call__(self, scope, receive, send):
579574
}
580575
else:
581576
assert "user" not in event
582-
583-
584-
@pytest.mark.parametrize("span_streaming", [True, False])
585-
def test_request_url(sentry_init, capture_events, capture_items, span_streaming):
586-
sentry_init(
587-
traces_sample_rate=1.0,
588-
integrations=[StarliteIntegration()],
589-
send_default_pii=True,
590-
_experiments={
591-
"trace_lifecycle": "stream" if span_streaming else "static",
592-
},
593-
)
594-
595-
starlite_app = starlite_app_factory()
596-
client = TestClient(
597-
starlite_app, base_url="http://testserver.local", root_path="/root"
598-
)
599-
600-
if span_streaming:
601-
items = capture_items("span")
602-
603-
client.get("/nomessage")
604-
605-
sentry_sdk.flush()
606-
spans = [item.payload for item in items]
607-
608-
(server_span,) = (
609-
span
610-
for span in spans
611-
if span["attributes"].get("sentry.op") == "http.server"
612-
)
613-
assert server_span["attributes"]["url.full"] == (
614-
"http://testserver.local/root/nomessage"
615-
)
616-
else:
617-
events = capture_events()
618-
619-
client.get("/nomessage")
620-
621-
(event,) = events
622-
assert event["request"]["url"] == "http://testserver.local/root/nomessage"

0 commit comments

Comments
 (0)