Skip to content

Commit 68a692c

Browse files
authored
Bump the minimum required version of the core SDK to 3.5 (#634)
1 parent 6b443cf commit 68a692c

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

.github/workflows/tests.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,16 +92,20 @@ jobs:
9292
missing-optional-packages-tests:
9393
name: Tests without optional packages
9494
runs-on: ubuntu-latest
95+
env:
96+
SYMFONY_REQUIRE: ${{ matrix.symfony-version }}
9597
strategy:
9698
fail-fast: false
9799
matrix:
98100
include:
99101
- php: '7.2'
100102
dependencies: lowest
103+
symfony-version: 3.4.*
101104
- php: '7.4'
102105
dependencies: highest
103106
- php: '8.0'
104107
dependencies: lowest
108+
symfony-version: 4.4.*
105109
- php: '8.1'
106110
dependencies: highest
107111

@@ -113,7 +117,8 @@ jobs:
113117
uses: shivammathur/setup-php@v2
114118
with:
115119
php-version: ${{ matrix.php }}
116-
coverage: xdebug
120+
coverage: pcov
121+
tools: flex
117122

118123
- name: Setup Problem Matchers for PHPUnit
119124
run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"php": "^7.2||^8.0",
2727
"jean85/pretty-package-versions": "^1.5 || ^2.0",
2828
"php-http/discovery": "^1.11",
29-
"sentry/sdk": "^3.1",
29+
"sentry/sdk": "^3.2",
3030
"symfony/cache-contracts": "^1.1||^2.4||^3.0",
3131
"symfony/config": "^3.4.44||^4.4.20||^5.0.11||^6.0",
3232
"symfony/console": "^3.4.44||^4.4.20||^5.0.11||^6.0",

tests/End2End/App/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ sentry:
22
tracing:
33
enabled: true
44
options:
5-
capture_silenced_errors: true
5+
capture_silenced_errors: false
66
error_types: E_ALL & ~E_USER_DEPRECATED
77
traces_sample_rate: 0
88

tests/End2End/End2EndTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,15 @@ public function testGetFatal(): void
162162
public function testNotice(): void
163163
{
164164
$client = static::createClient();
165+
166+
/** @var HubInterface $hub */
167+
$hub = $client->getContainer()->get('test.hub');
168+
$sentryClient = $hub->getClient();
169+
170+
$this->assertNotNull($sentryClient);
171+
172+
$sentryClient->getOptions()->setCaptureSilencedErrors(true);
173+
165174
$client->request('GET', '/notice');
166175

167176
$response = $client->getResponse();

0 commit comments

Comments
 (0)