feat(setup-sentry): Add toggle to setup sentry gha #104459
Draft
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if [ "${{ inputs.toggle }}" != "" ]; then | ||
| echo "Toggling off ${{ inputs.toggle }}" | ||
| devservices toggle ${{ inputs.toggle }} |
Contributor
There was a problem hiding this comment.
Bug: Unquoted shell variable allows command injection
The ${{ inputs.toggle }} value is directly interpolated into the shell command without quotes on line 132. If the toggle input contains special shell characters or malicious content (e.g., snuba; malicious-command), it could lead to command injection. While the input is quoted in the condition check on line 130, it's unquoted when passed to devservices toggle. Using an environment variable (like WORKDIR is handled) and quoting it would be safer.
joshuarli
reviewed
Dec 5, 2025
| required: false | ||
| default: 'default' | ||
| toggle: | ||
| description: 'Dependency to toggle off ' |
Member
There was a problem hiding this comment.
shouldn't this be dependency to toggle to local to be explicit?
and then devservices toggle foo local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to easily ensure devservices does not bring up container for service in CI. Will be useful for snuba