From 054b25e1c24721c62e6ff4eaabe96851087a5511 Mon Sep 17 00:00:00 2001 From: "Michael B. Gale" Date: Fri, 25 Sep 2026 14:58:43 +0100 Subject: [PATCH 1/2] Remove unnecessary `config` check --- lib/entry-points.js | 6 ------ src/start-proxy-action-post.ts | 6 ------ 2 files changed, 12 deletions(-) diff --git a/lib/entry-points.js b/lib/entry-points.js index cbeec24780..0b9e64fa3e 100644 --- a/lib/entry-points.js +++ b/lib/entry-points.js @@ -164199,12 +164199,6 @@ async function runWrapper9() { logger.info( "Debug mode is on. Uploading proxy log as Actions debugging artifact..." ); - if (config?.gitHubVersion.type === void 0) { - logger.warning( - `Did not upload debug artifacts because cannot determine the GitHub variant running.` - ); - return; - } const gitHubVersion = await getGitHubVersion(); checkGitHubVersionInRange(gitHubVersion, logger); await uploadArtifacts( diff --git a/src/start-proxy-action-post.ts b/src/start-proxy-action-post.ts index d300d528b6..c872207ac0 100644 --- a/src/start-proxy-action-post.ts +++ b/src/start-proxy-action-post.ts @@ -38,12 +38,6 @@ export async function runWrapper() { logger.info( "Debug mode is on. Uploading proxy log as Actions debugging artifact...", ); - if (config?.gitHubVersion.type === undefined) { - logger.warning( - `Did not upload debug artifacts because cannot determine the GitHub variant running.`, - ); - return; - } const gitHubVersion = await getGitHubVersion(); checkGitHubVersionInRange(gitHubVersion, logger); From 9fb2fa5f460cbdf6af333c849ec85eb0c87458b9 Mon Sep 17 00:00:00 2001 From: "Michael B. Gale" Date: Fri, 25 Sep 2026 15:02:13 +0100 Subject: [PATCH 2/2] Avoid duplicate `getApiDetails` in `getGitHubVersion` --- lib/entry-points.js | 5 +++-- src/api-client.ts | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/entry-points.js b/lib/entry-points.js index 0b9e64fa3e..a165a9b3b1 100644 --- a/lib/entry-points.js +++ b/lib/entry-points.js @@ -146768,9 +146768,10 @@ async function getGitHubVersionFromApi(apiClient, apiDetails) { } async function getGitHubVersion() { if (cachedGitHubVersion === void 0) { + const apiDetails = getApiDetails(); cachedGitHubVersion = await getGitHubVersionFromApi( - getApiClient(), - getApiDetails() + createApiClientWithDetails(apiDetails), + apiDetails ); } return cachedGitHubVersion; diff --git a/src/api-client.ts b/src/api-client.ts index bc6018877e..e509f5eea0 100644 --- a/src/api-client.ts +++ b/src/api-client.ts @@ -249,9 +249,10 @@ export async function getGitHubVersionFromApi( */ export async function getGitHubVersion(): Promise { if (cachedGitHubVersion === undefined) { + const apiDetails = getApiDetails(); cachedGitHubVersion = await getGitHubVersionFromApi( - getApiClient(), - getApiDetails(), + createApiClientWithDetails(apiDetails), + apiDetails, ); } return cachedGitHubVersion;