small enhancement to make rules that don't match not appear

Author: jsinglet

scripts/PSCodingStandards/Get-RuleForPath.ps1

@@ -28,6 +28,9 @@
 # is a substring of the path once the substitution `/src/` -> `/test/` is
 # applied  
 
+$global:ruleCacheC = $null;
+$global:ruleCacheCPP = $null;
+$global:enableRuleCache = $false 
 function Get-RuleForPath {
     param([Parameter(Mandatory)] 
         [string]
@@ -41,9 +44,30 @@ function Get-RuleForPath {
     $allQueries = @()
     $queriesToCheck = @()
 
-    # load all the queries 
-    foreach ($s in $AVAILABLE_SUITES) {
-        $allQueries += Get-RulesInSuite -Suite $s -Language $Language
+    if($global:enableRuleCache){
+        # load all the queries 
+        if($Language -eq 'cpp'){
+            $ruleCache = $global:ruleCacheCPP
+        }else{
+            $ruleCache = $global:ruleCacheC
+        }
+    }
+
+    if(-not $ruleCache){
+
+        foreach ($s in $AVAILABLE_SUITES) {
+            $allQueries += Get-RulesInSuite -Suite $s -Language $Language
+        }
+
+        if($global:enableRuleCache){
+            if($Language -eq 'cpp'){
+                $global:ruleCacheCPP = $allQueries
+            }else{
+                $global:ruleCacheC = $allQueries
+            }
+        }    
+    }else{
+        $allQueries = $ruleCache
     }
 
     $modifiedPathWithReplacement = Join-Path (Resolve-Path . -Relative) $Path 
@@ -57,12 +81,11 @@ function Get-RuleForPath {
 
     # for each query, create the test directory 
     foreach($q in $allQueries){
-
         # get test directory
         $testDirs = (Get-ATestDirectory -RuleObject $q -Language $Language)
         foreach($testDirectory in $testDirs){
             # resolve path to be compatible 
-            $testPath = Join-Path (Resolve-Path . -Relative) $testDirectory
+            $testPath = (Join-Path (Resolve-Path . -Relative) $testDirectory) + [IO.Path]::DirectorySeparatorChar
 
             # see if the TEST directory is a substring of the full path 
             if($modifiedPath.StartsWith($testPath)){

scripts/PSCodingStandards/Test-GetRuleForPath.ps1

@@ -0,0 +1,39 @@
+function Test-GetRuleForPath {
+param(
+    [Parameter(Mandatory)] 
+    [string]
+    $PR
+)
+
+$prData = (gh pr view -R github/codeql-coding-standards $PR --json headRefOid,headRepository,author,isCrossRepository,headRepositoryOwner,headRefName,files) | ConvertFrom-Json
+
+foreach($f in $prData.files){
+    try {
+        Write-Host "[C] Scanning file for relationship $($f.path)..."
+        $rulesToTest = Get-RuleForPath -Language c -Path "$($f.path)"
+     
+        Write-Host "[C] Got $($rulesToTest.Count) potential C rules..."
+     
+        foreach($r in $rulesToTest){
+            $ruleNames += $r.__memberof_rule 
+            Write-Host "[C] Found rule $r "
+        }
+    }catch{
+        Write-Host "No $Language rules found for path: $($f.path)"
+    }
+
+
+    try {
+        Write-Host "[CPP] Scanning file for relationship $($f.path)..."
+        $rulesToTest = Get-RuleForPath -Language cpp -Path "$($f.path)"
+     
+        Write-Host "[CPP] Got $($rulesToTest.Count) potential CPP rules..."
+     
+        foreach($r in $rulesToTest){
+            Write-Host "[CPP] Found rule $r "
+        }
+    }catch{
+        Write-Host "No CPP rules found for path: $($f.path)"
+    }
+}
+}