Replaces expensive getIdentityString() call

rak3-sh · rak3-sh · commit 31eea6cae79c · 2024-04-22T11:40:06.000+09:00
diff --git a/change_notes/2024-04-22-improve-a13-2-2.md b/change_notes/2024-04-22-improve-a13-2-2.md
@@ -0,0 +1,2 @@
+- `A13-2-2` - `BinaryOperatorAndBitwiseOperatorReturnAPrvalue.ql`:
+    - Replaced the usage of getIdentityString() with toString() to avoid expensive computation to display the Operator names which were causing crashes on production code.
diff --git a/cpp/autosar/src/rules/A13-2-2/BinaryOperatorAndBitwiseOperatorReturnAPrvalue.ql b/cpp/autosar/src/rules/A13-2-2/BinaryOperatorAndBitwiseOperatorReturnAPrvalue.ql
@@ -31,5 +31,5 @@ where
     o.getType() instanceof ReferenceType
   )
 select o,
-  "User-defined bitwise or arithmetic operator " + getIdentityString(o) +
+  "User-defined bitwise or arithmetic operator " + o.toString() +
     " does not return a prvalue."

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+- `A13-2-2` - `BinaryOperatorAndBitwiseOperatorReturnAPrvalue.ql`:
	`2`	`+ - Replaced the usage of getIdentityString() with toString() to avoid expensive computation to display the Operator names which were causing crashes on production code.`
Original file line number	Diff line number	Diff line change
`@@ -31,5 +31,5 @@ where`
`31`	`31`	`o.getType() instanceof ReferenceType`
`32`	`32`	`)`
`33`	`33`	`select o,`
`34`		`- "User-defined bitwise or arithmetic operator " + getIdentityString(o) +`
	`34`	`+ "User-defined bitwise or arithmetic operator " + o.toString() +`
`35`	`35`	`" does not return a prvalue."`