Fix RULE-8-4

Author: mbaluda

c/misra/src/rules/RULE-8-4/CompatibleDeclarationObjectDefined.ql

@@ -23,16 +23,10 @@ where
   not isExcluded(decl1, Declarations4Package::compatibleDeclarationObjectDefinedQuery()) and
   decl1.isDefinition() and
   decl1.getDeclaration() instanceof ExternalIdentifiers and
-  (
-    //no declaration matches exactly
-    not exists(VariableDeclarationEntry decl2 |
-      not decl2.isDefinition() and decl2.getDeclaration() = decl1.getDeclaration()
-    ) and
-    //and none is close enough
-    not exists(VariableDeclarationEntry decl2 |
-      not decl2.isDefinition() and
-      decl1.getVariable().getQualifiedName() = decl2.getVariable().getQualifiedName() and
-      typesCompatible(decl1.getType(), decl2.getType())
-    )
+  // no declaration matches
+  not exists(VariableDeclarationEntry decl2 |
+    not decl2.isDefinition() and
+    decl1.getVariable().getQualifiedName() = decl2.getVariable().getQualifiedName() and
+    typesCompatible(decl1.getType(), decl2.getType())
   )
 select decl1, "No separate compatible declaration found for this definition."

c/misra/test/rules/RULE-8-4/CompatibleDeclarationFunctionDefined.expected

@@ -1,2 +1,3 @@
-| function2.c:5:6:5:7 | definition of f3 | No separate compatible declaration found for this definition. |
-| function2.c:7:6:7:7 | definition of f4 | No separate compatible declaration found for this definition. |
+| object1.c:4:12:4:13 | definition of i1 | No separate compatible declaration found for this definition. |
+| object1.c:6:5:6:6 | definition of i2 | No separate compatible declaration found for this definition. |
+| object2.c:1:7:1:8 | definition of i3 | No separate compatible declaration found for this definition. |

c/misra/test/rules/RULE-8-4/object1.c

@@ -1,11 +1,10 @@
 extern int i;
-i = 0; // COMPLIANT
+int i = 0; // COMPLIANT
 
 extern int i1 = 0; // NON_COMPLIANT
 
 int i2 = 0; // NON_COMPLIANT
 
-// not detected as `short i3` exists
-extern int i3; // NON_COMPLIANT[FALSE_NEGATIVE]
+extern int i3;
 
-extern int i4; // COMPLIANT
+extern int i4;

c/misra/test/rules/RULE-8-4/object2.c

@@ -1,4 +1,3 @@
-// not detected as `extern int i3` exists
-short i3 = 0; // NON_COMPLIANT[FALSE_NEGATIVE]
+short i3 = 0; // NON_COMPLIANT
 
 signed int i4 = 0; // COMPLIANT