Merge branch 'michaelrfairhurst/package-undefined-behavior' into michaelrfairhurst/rule-4-1-3-detect-data-races

MichaelRFairhurst · MichaelRFairhurst · commit 65e525d3646b · 2026-03-09T19:47:21.000-07:00
diff --git a/.github/workflows/code-scanning-pack-gen.yml b/.github/workflows/code-scanning-pack-gen.yml
@@ -10,6 +10,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
   push:
     branches:
       - main
diff --git a/.github/workflows/codeql_unit_tests.yml b/.github/workflows/codeql_unit_tests.yml
@@ -15,6 +15,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
 
 jobs:
  
diff --git a/.github/workflows/extra-rule-validation.yml b/.github/workflows/extra-rule-validation.yml
@@ -15,6 +15,7 @@ on:
       - main
       - "rc/**"
       - next
+      - michaelrfairhurst/package-undefined-behavior
 
 
 jobs:
diff --git a/.github/workflows/tooling-unit-tests.yml b/.github/workflows/tooling-unit-tests.yml
@@ -15,6 +15,7 @@ on:
       - main
       - "rc/**"
       - next
+      - michaelrfairhurst/package-undefined-behavior
 
 jobs:
   prepare-supported-codeql-env-matrix:
diff --git a/.github/workflows/validate-package-files.yml b/.github/workflows/validate-package-files.yml
@@ -9,6 +9,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
 
 jobs:
   validate-package-files:
diff --git a/.github/workflows/validate-query-formatting.yml b/.github/workflows/validate-query-formatting.yml
@@ -9,6 +9,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
 
 env:
     XARGS_MAX_PROCS: 4
diff --git a/.github/workflows/validate-query-help.yml b/.github/workflows/validate-query-help.yml
@@ -9,6 +9,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
 
 jobs:
   validate-query-help-files:
diff --git a/.github/workflows/validate-query-test-case-formatting.yml b/.github/workflows/validate-query-test-case-formatting.yml
@@ -9,6 +9,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
 
 env:
   XARGS_MAX_PROCS: 4
diff --git a/cpp/misra/src/rules/RULE-4-1-3/CriticalUnspecifiedBehavior.ql b/cpp/misra/src/rules/RULE-4-1-3/CriticalUnspecifiedBehavior.ql
@@ -0,0 +1,22 @@
+/**
+ * @id cpp/misra/critical-unspecified-behavior
+ * @name RULE-4-1-3: There shall be no occurrence of critical unspecified behaviour
+ * @description Critical unspecified behaviour impacts the observable behaviour of the abstract
+ *              machine and means a program is not guaranteed to behave predictably.
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/misra/id/rule-4-1-3
+ *       correctness
+ *       scope/system
+ *       external/misra/enforcement/undecidable
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.cpp.misra
+
+from
+where
+  not isExcluded(x, UndefinedPackage::criticalUnspecifiedBehaviorQuery()) and
+select
diff --git a/cpp/misra/src/rules/RULE-4-1-3/CriticalUnspecifiedBehaviorAudit.ql b/cpp/misra/src/rules/RULE-4-1-3/CriticalUnspecifiedBehaviorAudit.ql
@@ -0,0 +1,23 @@
+/**
+ * @id cpp/misra/critical-unspecified-behavior-audit
+ * @name RULE-4-1-3: Audit: there shall be no occurrence of critical unspecified behaviour
+ * @description Critical unspecified behaviour impacts the observable behaviour of the abstract
+ *              machine and means a program is not guaranteed to behave predictably.
+ * @kind problem
+ * @precision low
+ * @problem.severity error
+ * @tags external/misra/id/rule-4-1-3
+ *       correctness
+ *       scope/system
+ *       external/misra/audit
+ *       external/misra/enforcement/undecidable
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.cpp.misra
+
+from
+where
+  not isExcluded(x, UndefinedPackage::criticalUnspecifiedBehaviorAuditQuery()) and
+select
diff --git a/cpp/misra/src/rules/RULE-4-1-3/UndefinedBehavior.ql b/cpp/misra/src/rules/RULE-4-1-3/UndefinedBehavior.ql
@@ -0,0 +1,23 @@
+/**
+ * @id cpp/misra/undefined-behavior
+ * @name RULE-4-1-3: There shall be no occurrence of undefined behaviour
+ * @description It is not possible to reason about the behaviour of any program that contains
+ *              instances of undefined behaviour, which can cause unpredictable results that are
+ *              particularly difficult to detect during testing.
+ * @kind problem
+ * @precision high
+ * @problem.severity error
+ * @tags external/misra/id/rule-4-1-3
+ *       correctness
+ *       scope/system
+ *       external/misra/enforcement/undecidable
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.cpp.misra
+
+from
+where
+  not isExcluded(x, UndefinedPackage::undefinedBehaviorQuery()) and
+select
diff --git a/cpp/misra/src/rules/RULE-4-1-3/UndefinedBehaviorAudit.ql b/cpp/misra/src/rules/RULE-4-1-3/UndefinedBehaviorAudit.ql
@@ -0,0 +1,24 @@
+/**
+ * @id cpp/misra/undefined-behavior-audit
+ * @name RULE-4-1-3: Audit: there shall be no occurrence of undefined behaviour
+ * @description It is not possible to reason about the behaviour of any program that contains
+ *              instances of undefined behaviour, which can cause unpredictable results that are
+ *              particularly difficult to detect during testing.
+ * @kind problem
+ * @precision low
+ * @problem.severity error
+ * @tags external/misra/id/rule-4-1-3
+ *       correctness
+ *       scope/system
+ *       external/misra/audit
+ *       external/misra/enforcement/undecidable
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.cpp.misra
+
+from
+where
+  not isExcluded(x, UndefinedPackage::undefinedBehaviorAuditQuery()) and
+select
diff --git a/cpp/misra/test/rules/RULE-4-1-3/CriticalUnspecifiedBehavior.expected b/cpp/misra/test/rules/RULE-4-1-3/CriticalUnspecifiedBehavior.expected
@@ -0,0 +1 @@
+No expected results have yet been specified
diff --git a/cpp/misra/test/rules/RULE-4-1-3/CriticalUnspecifiedBehavior.qlref b/cpp/misra/test/rules/RULE-4-1-3/CriticalUnspecifiedBehavior.qlref
@@ -0,0 +1 @@
+rules/RULE-4-1-3/CriticalUnspecifiedBehavior.ql
diff --git a/cpp/misra/test/rules/RULE-4-1-3/CriticalUnspecifiedBehaviorAudit.expected b/cpp/misra/test/rules/RULE-4-1-3/CriticalUnspecifiedBehaviorAudit.expected
@@ -0,0 +1 @@
+No expected results have yet been specified
diff --git a/cpp/misra/test/rules/RULE-4-1-3/CriticalUnspecifiedBehaviorAudit.qlref b/cpp/misra/test/rules/RULE-4-1-3/CriticalUnspecifiedBehaviorAudit.qlref
@@ -0,0 +1 @@
+rules/RULE-4-1-3/CriticalUnspecifiedBehaviorAudit.ql
diff --git a/cpp/misra/test/rules/RULE-4-1-3/UndefinedBehavior.expected b/cpp/misra/test/rules/RULE-4-1-3/UndefinedBehavior.expected
@@ -0,0 +1 @@
+No expected results have yet been specified
diff --git a/cpp/misra/test/rules/RULE-4-1-3/UndefinedBehavior.qlref b/cpp/misra/test/rules/RULE-4-1-3/UndefinedBehavior.qlref
@@ -0,0 +1 @@
+rules/RULE-4-1-3/UndefinedBehavior.ql
diff --git a/cpp/misra/test/rules/RULE-4-1-3/UndefinedBehaviorAudit.expected b/cpp/misra/test/rules/RULE-4-1-3/UndefinedBehaviorAudit.expected
@@ -0,0 +1 @@
+No expected results have yet been specified
diff --git a/cpp/misra/test/rules/RULE-4-1-3/UndefinedBehaviorAudit.qlref b/cpp/misra/test/rules/RULE-4-1-3/UndefinedBehaviorAudit.qlref
@@ -0,0 +1 @@
+rules/RULE-4-1-3/UndefinedBehaviorAudit.ql

-Original file line number
+Diff line change
       - main
       - next
       - "rc/**"
 +      - michaelrfairhurst/package-undefined-behavior
 jobs: