M14-6-1: Handle overloading

Previously the logic of this query asserted that the function call did
not target the selected function in the dependent base type with the
same name. In theory this is wrong, as overloading can permit multiple
functions declarations with the same name, but different signatures, so
we now say that the target is not declared on the same base type.

In practice, such results would be excluded because to call an overload
of the same function would always have a qualifier in this case, however
this logic makes the intention clearer.

Author: lcartey

cpp/autosar/src/rules/M14-6-1/NameInDependentBase.qll

@@ -24,7 +24,7 @@ TemplateClass getADependentBaseType(TemplateClass t) {
 FunctionCall parentMemberFunctionCall(TemplateClass t) {
   exists(TemplateClass dependentBaseType, MemberFunction dependentTypeFunction, Function target |
     dependentBaseType = getADependentBaseType(t) and
-    not target = dependentTypeFunction and
+    not target.getDeclaringType() = dependentBaseType and
     dependentBaseType.getAMember() = dependentTypeFunction and
     target.getName() = dependentTypeFunction.getName() and
     result = target.getACallToThisFunction() and
@@ -39,7 +39,7 @@ FunctionCall parentMemberFunctionCall(TemplateClass t) {
 FunctionAccess parentMemberFunctionAccess(TemplateClass t) {
   exists(TemplateClass dependentBaseType, MemberFunction dependentTypeFunction, Function target |
     dependentBaseType = getADependentBaseType(t) and
-    not target = dependentTypeFunction and
+    not target.getDeclaringType() = dependentBaseType and
     dependentBaseType.getAMember() = dependentTypeFunction and
     target.getName() = dependentTypeFunction.getName() and
     result = target.getAnAccess() and
@@ -56,7 +56,7 @@ Access parentMemberAccess(TemplateClass t) {
     TemplateClass dependentBaseType, MemberVariable dependentTypeMemberVariable, Variable target
   |
     dependentBaseType = getADependentBaseType(t) and
-    not target = dependentTypeMemberVariable and
+    not target.getDeclaringType() = dependentBaseType and
     dependentBaseType.getAMemberVariable() = dependentTypeMemberVariable and
     target.getName() = dependentTypeMemberVariable.getName() and
     result = target.getAnAccess() and