Merge pull request #14311 from hvitved/csharp/dependency-manager-generated-files

C#: Expose generated files in `DependencyManager`

Author: hvitved

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs

@@ -23,7 +23,8 @@ public sealed class DependencyManager : IDisposable
         private readonly IDictionary<string, string> unresolvedReferences = new ConcurrentDictionary<string, string>();
         private int failedProjects;
         private int succeededProjects;
-        private readonly List<string> allSources;
+        private readonly List<string> nonGeneratedSources;
+        private readonly List<string> generatedSources;
         private int conflictedReferences = 0;
         private readonly IDependencyOptions options;
         private readonly DirectoryInfo sourceDir;
@@ -65,7 +66,8 @@ public DependencyManager(string srcDir, IDependencyOptions options, ILogger logg
             var allNonBinaryFiles = allFiles.Where(f => !binaryFileExtensions.Contains(f.Extension.ToLowerInvariant())).ToList();
             var smallNonBinaryFiles = allNonBinaryFiles.SelectSmallFiles(progressMonitor).SelectFileNames();
             this.fileContent = new FileContent(progressMonitor, smallNonBinaryFiles);
-            this.allSources = allNonBinaryFiles.SelectFileNamesByExtension(".cs").ToList();
+            this.nonGeneratedSources = allNonBinaryFiles.SelectFileNamesByExtension(".cs").ToList();
+            this.generatedSources = new();
             var allProjects = allNonBinaryFiles.SelectFileNamesByExtension(".csproj");
             var solutions = options.SolutionFile is not null
                 ? new[] { options.SolutionFile }
@@ -219,7 +221,7 @@ private void GenerateSourceFileFromImplicitUsings()
                     }
                 }
 
-                this.allSources.Add(path);
+                this.generatedSources.Add(path);
             }
         }
 
@@ -241,7 +243,7 @@ private void GenerateSourceFilesFromWebViews(List<FileInfo> allFiles)
                         var razor = new Razor(sdk, dotnet, progressMonitor);
                         var targetDir = GetTemporaryWorkingDirectory("razor");
                         var generatedFiles = razor.GenerateFiles(views, usedReferences.Keys, targetDir);
-                        this.allSources.AddRange(generatedFiles);
+                        this.generatedSources.AddRange(generatedFiles);
                     }
                     catch (Exception ex)
                     {
@@ -384,10 +386,15 @@ private void ResolveConflicts()
         /// </summary>
         public IEnumerable<string> ProjectSourceFiles => sources.Where(s => s.Value).Select(s => s.Key);
 
+        /// <summary>
+        /// All of the generated source files in the source directory.
+        /// </summary>
+        public IEnumerable<string> GeneratedSourceFiles => generatedSources;
+
         /// <summary>
         /// All of the source files in the source directory.
         /// </summary>
-        public IEnumerable<string> AllSourceFiles => allSources;
+        public IEnumerable<string> AllSourceFiles => generatedSources.Concat(nonGeneratedSources);
 
         /// <summary>
         /// List of assembly IDs which couldn't be resolved.