Revert unneeded changes and simplify code

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs

@@ -157,7 +157,7 @@ private HashSet<string> AddFrameworkDlls(HashSet<string> dllPaths)
             return frameworkLocations;
         }
 
-        private void RestoreNugetPackages(List<FileInfo> allNonBinaryFiles, List<string> allProjects, List<string> allSolutions, HashSet<string> dllPaths)
+        private void RestoreNugetPackages(List<FileInfo> allNonBinaryFiles, IEnumerable<string> allProjects, IEnumerable<string> allSolutions, HashSet<string> dllPaths)
         {
             try
             {
@@ -719,7 +719,7 @@ private void AnalyseProject(FileInfo project)
         /// Returns a list of projects that are up to date with respect to restore.
         /// </summary>
         /// <param name="solutions">A list of paths to solution files.</param>
-        private IEnumerable<string> RestoreSolutions(List<string> solutions, out IEnumerable<string> assets)
+        private IEnumerable<string> RestoreSolutions(IEnumerable<string> solutions, out IEnumerable<string> assets)
         {
             var successCount = 0;
             var assetFiles = new List<string>();
@@ -841,21 +841,13 @@ private void DownloadMissingPackages(List<FileInfo> allFiles, ISet<string> dllPa
                     if (!res.Success)
                     {
                         logger.LogInfo($"Failed to restore nuget package {package}");
-                    }
-                    else
-                    {
-                        lock (sync)
-                        {
-                            successCount++;
-                        }
+                        return;
                     }
                 }
-                else
+
+                lock (sync)
                 {
-                    lock (sync)
-                    {
-                        successCount++;
-                    }
+                    successCount++;
                 }
             });
 

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackages.cs

@@ -107,7 +107,7 @@ private string DownloadNugetExe(string sourceDir)
         /// Restore all files in a specified package.
         /// </summary>
         /// <param name="package">The package file.</param>
-        private bool RestoreNugetPackage(string package)
+        private bool TryRestoreNugetPackage(string package)
         {
             logger.LogInfo($"Restoring file {package}...");
 
@@ -157,17 +157,7 @@ private bool RestoreNugetPackage(string package)
         /// </summary>
         public int InstallPackages()
         {
-            var success = 0;
-            foreach (var package in packageFiles)
-            {
-                var result = RestoreNugetPackage(package.FullName);
-                if (result)
-                {
-                    success++;
-                }
-            }
-
-            return success;
+            return packageFiles.Count(package => TryRestoreNugetPackage(package.FullName));
         }
     }
 }

csharp/extractor/Semmle.Extraction.CSharp.Standalone/Extractor.cs

@@ -5,14 +5,14 @@
 using System.Linq;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
+using Semmle.Extraction.CSharp.DependencyFetching;
 using Semmle.Util;
 using Semmle.Util.Logging;
 
 namespace Semmle.Extraction.CSharp.Standalone
 {
     public static class Extractor
     {
-
         private static IEnumerable<Action> GetResolvedReferencesStandalone(IEnumerable<string> referencePaths, BlockingCollection<MetadataReference> references)
         {
             return referencePaths.Select<string, Action>(path => () =>
@@ -138,10 +138,9 @@ public static ExitCode Run(Options options)
 
             using var logger = new ConsoleLogger(options.Verbosity, logThreadId: true);
             logger.Log(Severity.Info, "Extracting C# in buildless mode");
-            using var a = new Analysis(logger, options);
-            var sourceFileCount = a.Extraction.Sources.Count;
+            using var dependencyManager = new DependencyManager(options.SrcDir, options.Dependencies, logger);
 
-            if (sourceFileCount == 0)
+            if (!dependencyManager.AllSourceFiles.Any())
             {
                 logger.Log(Severity.Error, "No source files found");
                 return ExitCode.Errors;
@@ -152,7 +151,7 @@ public static ExitCode Run(Options options)
             logger.Log(Severity.Info, "");
             logger.Log(Severity.Info, "Extracting...");
             ExtractStandalone(
-                new ExtractionInput(a.Extraction.Sources, a.References, a.CompilationInfos),
+                new ExtractionInput(dependencyManager.AllSourceFiles, dependencyManager.ReferenceFiles, dependencyManager.CompilationInfos),
                 new ExtractionProgress(logger),
                 fileLogger,
                 options);

csharp/extractor/Semmle.Extraction.CSharp.Standalone/Program.cs

@@ -5,51 +5,6 @@
 
 namespace Semmle.Extraction.CSharp.Standalone
 {
-    /// <summary>
-    ///     One independent run of the extractor.
-    /// </summary>
-    internal class Extraction
-    {
-        public Extraction(string directory)
-        {
-            Directory = directory;
-        }
-
-        public string Directory { get; }
-        public List<string> Sources { get; } = new List<string>();
-    };
-
-    /// <summary>
-    ///     Searches for source/references and creates separate extractions.
-    /// </summary>
-    internal sealed class Analysis : IDisposable
-    {
-        public Analysis(ILogger logger, Options options)
-        {
-            dependencyManager = new DependencyManager(options.SrcDir, options.Dependencies, logger);
-            References = dependencyManager.ReferenceFiles;
-            Extraction = new Extraction(options.SrcDir);
-            Extraction.Sources.AddRange(dependencyManager.AllSourceFiles);
-            CompilationInfos = dependencyManager.CompilationInfos;
-        }
-
-        public IEnumerable<string> References { get; }
-
-        /// <summary>
-        /// The extraction configuration.
-        /// </summary>
-        public Extraction Extraction { get; }
-
-        public IEnumerable<(string, string)> CompilationInfos { get; }
-
-        private readonly DependencyManager dependencyManager;
-
-        public void Dispose()
-        {
-            dependencyManager.Dispose();
-        }
-    };
-
     public class Program
     {
         public static int Main(string[] args)

csharp/extractor/Semmle.Extraction.CSharp/Extractor/Analyser.cs

@@ -21,7 +21,7 @@ public class Analyser : IDisposable
         protected CSharpCompilation? compilation;
         protected CommonOptions? options;
         private protected Entities.Compilation? compilationEntity;
-        private TrapWriter? compilationTrapFile;
+        private IDisposable? compilationTrapFile;
 
         private readonly object progressMutex = new object();