Merge pull request #15660 from tamasvajk/feature/code-quality

C#: Use `nameof` in nullability attributes

Author: tamasvajk

csharp/autobuilder/Semmle.Autobuild.Shared/BuildActions.cs

@@ -140,7 +140,7 @@ public interface IBuildActions
         /// <summary>
         /// Returns the file name and extension of the specified path string.
         /// </summary>
-        [return: NotNullIfNotNull("path")]
+        [return: NotNullIfNotNull(nameof(path))]
         string? GetFileName(string? path);
 
         /// <summary>

csharp/extractor/Semmle.Extraction.CSharp/Entities/Constructor.cs

@@ -126,7 +126,7 @@ private ConstructorDeclarationSyntax? Syntax
             }
         }
 
-        [return: NotNullIfNotNull("constructor")]
+        [return: NotNullIfNotNull(nameof(constructor))]
         public static new Constructor? Create(Context cx, IMethodSymbol? constructor)
         {
             if (constructor is null)

csharp/extractor/Semmle.Extraction.CSharp/Entities/Method.cs

@@ -232,7 +232,7 @@ public static void AddExplicitInterfaceQualifierToId(Context cx, EscapingTextWri
         /// <param name="cx"></param>
         /// <param name="methodDecl"></param>
         /// <returns></returns>
-        [return: NotNullIfNotNull("methodDecl")]
+        [return: NotNullIfNotNull(nameof(methodDecl))]
         public static Method? Create(Context cx, IMethodSymbol? methodDecl)
         {
             if (methodDecl is null)

csharp/extractor/Semmle.Extraction.CSharp/SymbolExtensions.cs

@@ -591,7 +591,7 @@ public static bool IsSourceDeclaration(this IParameterSymbol parameter)
         public static INamedTypeSymbol? GetNonObjectBaseType(this ITypeSymbol symbol, Context cx) =>
             symbol is ITypeParameterSymbol || SymbolEqualityComparer.Default.Equals(symbol.BaseType, cx.Compilation.ObjectType) ? null : symbol.BaseType;
 
-        [return: NotNullIfNotNull("symbol")]
+        [return: NotNullIfNotNull(nameof(symbol))]
         public static IEntity? CreateEntity(this Context cx, ISymbol symbol)
         {
             if (symbol is null)