From a8720c7807f853243bddb1f94cb2e608a9b733f0 Mon Sep 17 00:00:00 2001 From: Rajkumar TS Date: Fri, 10 Jul 2026 14:37:49 -0400 Subject: [PATCH] chore: add pull request template Standardizes PR descriptions with a Summary, Test plan, and Manual verification section that guides reviewers through testing with and without the change using a local cli-engine path override. Co-authored-by: Cursor --- .github/pull_request_template.md | 49 ++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000..774e5ef --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,49 @@ +## Summary + +* + +## Test plan + +* `cargo fmt --all --check` +* `cargo clippy --all-targets -- -D warnings` +* `cargo test --all-targets` + +### Manual verification + + + +**Setup:** + +```bash +# In the cli repo, temporarily override the engine dependency: +cd cli/rust +# Edit Cargo.toml → cli-engine = { features = ["pkce-auth"], path = "../../cli-engine" } +cargo build --release && cp target/release/gddy ~/.local/bin/gddy +``` + +**Test WITHOUT the fix (baseline):** + +```bash +cd cli-engine && git checkout main +cd cli/rust && cargo build --release && cp target/release/gddy ~/.local/bin/gddy +# +# Expected: +``` + +**Test WITH the fix:** + +```bash +cd cli-engine && git checkout +cd cli/rust && cargo build --release && cp target/release/gddy ~/.local/bin/gddy +# +# Expected: +``` + +**Cleanup:** + +```bash +# Revert cli/rust/Cargo.toml back to: +# cli-engine = { features = ["pkce-auth"], version = "" } +```