feat: optimize message handling and improve tests

- Change message references to pointers in various functions
- Add dependency: github.com/appleboy/com v0.1.7
- Add new benchmark test: BenchmarkNewMessage
- Update string to byte conversion using bytesconv.StrToBytes from appleboy/com package
- Update comments in queue.go for better clarity

Signed-off-by: appleboy <appleboy.tw@gmail.com>

Author: appleboy

benchmark_test.go

@@ -31,7 +31,7 @@ func testQueue(b *testing.B, pool testqueue) {
 	b.ResetTimer()
 	for n := 0; n < b.N; n++ {
 		for i := 0; i < count; i++ {
-			_ = pool.Queue(message)
+			_ = pool.Queue(&message)
 			_, _ = pool.Request()
 		}
 	}
@@ -60,7 +60,7 @@ func BenchmarkQueueTask(b *testing.B) {
 	})
 
 	for n := 0; n < b.N; n++ {
-		if err := q.queue(m); err != nil {
+		if err := q.queue(&m); err != nil {
 			b.Fatal(err)
 		}
 	}
@@ -81,7 +81,7 @@ func BenchmarkQueue(b *testing.B) {
 	m.Encode()
 
 	for n := 0; n < b.N; n++ {
-		if err := q.queue(m); err != nil {
+		if err := q.queue(&m); err != nil {
 			b.Fatal(err)
 		}
 	}
@@ -113,7 +113,7 @@ func BenchmarkQueue(b *testing.B) {
 func BenchmarkRingWithTask(b *testing.B) {
 	b.ReportAllocs()
 
-	task := &job.Message{
+	task := job.Message{
 		Timeout: 100 * time.Millisecond,
 		Task: func(_ context.Context) error {
 			return nil
@@ -131,6 +131,6 @@ func BenchmarkRingWithTask(b *testing.B) {
 	)
 
 	for n := 0; n < b.N; n++ {
-		_ = q.run(task)
+		_ = q.run(&task)
 	}
 }

go.mod

@@ -3,6 +3,7 @@ module github.com/golang-queue/queue
 go 1.18
 
 require (
+	github.com/appleboy/com v0.1.7
 	github.com/golang/mock v1.6.0
 	github.com/jpillora/backoff v1.0.0
 	github.com/stretchr/testify v1.8.4

go.sum

@@ -1,3 +1,5 @@
+github.com/appleboy/com v0.1.7 h1:4lYTFNoMAAXGGIC8lDxVg/NY+1aXbYqfAWN05cZhd0M=
+github.com/appleboy/com v0.1.7/go.mod h1:JUK+oH0SXCLRH57pDMJx6VWVsm8CPdajalmRSWwamBE=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

job/benchmark_test.go

@@ -21,6 +21,21 @@ func BenchmarkNewTask(b *testing.B) {
 	}
 }
 
+func BenchmarkNewMessage(b *testing.B) {
+	b.ReportAllocs()
+	for i := 0; i < b.N; i++ {
+		_ = NewMessage(mockMessage{
+			message: "foo",
+		},
+			AllowOption{
+				RetryCount: Int64(100),
+				RetryDelay: Time(30 * time.Millisecond),
+				Timeout:    Time(3 * time.Millisecond),
+			},
+		)
+	}
+}
+
 func BenchmarkNewOption(b *testing.B) {
 	b.ReportAllocs()
 	for i := 0; i < b.N; i++ {

job/job.go

@@ -68,10 +68,10 @@ func (m *Message) Encode() {
 }
 
 // NewMessage create new message
-func NewMessage(m core.QueuedMessage, opts ...AllowOption) *Message {
+func NewMessage(m core.QueuedMessage, opts ...AllowOption) Message {
 	o := NewOptions(opts...)
 
-	return &Message{
+	return Message{
 		RetryCount:  o.retryCount,
 		RetryDelay:  o.retryDelay,
 		RetryFactor: o.retryFactor,
@@ -83,10 +83,10 @@ func NewMessage(m core.QueuedMessage, opts ...AllowOption) *Message {
 }
 
 // NewTask create new task
-func NewTask(task TaskFunc, opts ...AllowOption) *Message {
+func NewTask(task TaskFunc, opts ...AllowOption) Message {
 	o := NewOptions(opts...)
 
-	return &Message{
+	return Message{
 		Timeout:     o.timeout,
 		RetryCount:  o.retryCount,
 		RetryDelay:  o.retryDelay,

job/job_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/appleboy/com/bytesconv"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -12,7 +13,7 @@ type mockMessage struct {
 }
 
 func (m mockMessage) Bytes() []byte {
-	return []byte(m.message)
+	return bytesconv.StrToBytes(m.message)
 }
 
 func TestMessageEncodeDecode(t *testing.T) {

queue.go

@@ -119,13 +119,13 @@ func (q *Queue) Queue(message core.QueuedMessage, opts ...job.AllowOption) error
 	data := job.NewMessage(message, opts...)
 	data.Encode()
 
-	return q.queue(data)
+	return q.queue(&data)
 }
 
 // QueueTask to queue single task
 func (q *Queue) QueueTask(task job.TaskFunc, opts ...job.AllowOption) error {
 	data := job.NewTask(task, opts...)
-	return q.queue(data)
+	return q.queue(&data)
 }
 
 func (q *Queue) queue(m *job.Message) error {
@@ -266,6 +266,7 @@ func (q *Queue) UpdateWorkerCount(num int) {
 	q.schedule()
 }
 
+// schedule to check worker number
 func (q *Queue) schedule() {
 	q.Lock()
 	defer q.Unlock()
@@ -279,7 +280,7 @@ func (q *Queue) schedule() {
 	}
 }
 
-// start handle job
+// start to start all worker
 func (q *Queue) start() {
 	tasks := make(chan core.QueuedMessage, 1)
 

queue_test.go

@@ -6,6 +6,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/appleboy/com/bytesconv"
 	"github.com/golang-queue/queue/core"
 	"github.com/golang-queue/queue/job"
 	"github.com/golang-queue/queue/mocks"
@@ -24,7 +25,7 @@ type mockMessage struct {
 }
 
 func (m mockMessage) Bytes() []byte {
-	return []byte(m.message)
+	return bytesconv.StrToBytes(m.message)
 }
 
 func TestNewQueueWithZeroWorker(t *testing.T) {