Skip to content

Commit 8947f09

Browse files
committed
runtime: skip mayMoreStackMove in goroutine leak tests
mayMoreStackMove may introduce more scheduler chaos because of all the stack movement (not as much as mayMoreStackPreempt) so let's disable the tests here too, since we have evidence that they can produce false negatives under this configuration. Though we're not 100% sure why this is happening yet, let's at least stop the flow of flaky failures. For #75729. Change-Id: I16d13dba9a61fbd47563b21cbf188e4754f58213 Reviewed-on: https://go-review.googlesource.com/c/go/+/726526 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com>
1 parent 44cb824 commit 8947f09

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/runtime/goroutineleakprofile_test.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,13 @@ import (
1414
)
1515

1616
func TestGoroutineLeakProfile(t *testing.T) {
17-
if strings.Contains(os.Getenv("GOFLAGS"), "mayMoreStackPreempt") {
18-
// Some tests have false negatives under mayMoreStackPreempt. This may be a test-only issue,
19-
// but needs more investigation.
20-
testenv.SkipFlaky(t, 75729)
17+
// Some tests have false negatives under mayMoreStackPreempt and mayMoreStackMove.
18+
// This may be a test-only issue in that they're just sensitive to scheduling, but it
19+
// needs more investigation.
20+
for _, cfg := range []string{"mayMoreStackPreempt", "mayMoreStackMove"} {
21+
if strings.Contains(os.Getenv("GOFLAGS"), cfg) {
22+
testenv.SkipFlaky(t, 75729)
23+
}
2124
}
2225

2326
// Goroutine leak test case.

0 commit comments

Comments
 (0)