Add a boot timeout thread.#2593
Open
3405691582 wants to merge 1 commit into
Open
Conversation
3405691582
force-pushed
the
508320217_1
branch
2 times, most recently
from
4bc1140 to
7fc6ed3
Compare
Databean
approved these changes
May 21, 2026
3405691582
force-pushed
the
508320217_1
branch
4 times, most recently
from
1e33e53 to
27c007e
Compare
Databean
approved these changes
May 21, 2026
Add a timeout thread to the state machine. Once both threads start, the timeout thread will wait until the boot completion event is received, the boot affirmatively fails, or the timeout gets triggered. Then we attempt to inform the launcher, otherwise we abend. This way, we should have more deterministic stopping conditions. We should perhaps expose the timeout flag more to the user, but this will suffice for now. Bug: 508320217
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a timeout thread to the state machine. Once both threads start, the timeout thread will wait until the boot completion event is received, the boot affirmatively fails, or the timeout gets triggered. Then we attempt to inform the launcher, otherwise we abend. This way, we should have more deterministic stopping conditions.
We should perhaps expose the timeout flag more to the user, but this will suffice for now.
Bug: 508320217