Reapply "Set up shared library targets."#2594
Open
3405691582 wants to merge 2 commits into
Open
Conversation
This reverts commit 5c24748.
Collaborator
Author
3405691582
force-pushed
the
509968291_5
branch
2 times, most recently
from
de855d2 to
1b68080
Compare
Keeping it would necessitate duplicating the libbase_shared target into Android, since we deduplicate back there when Copybara'ing. The library is small, so we don't lose very much right now. This does mean this should effectively be applied to google#2573, but it is more straightforward to add a new commit here.
Databean
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5c24748.