cvd: Begin simplifying creation analyzer#2606
Open
jemoreira wants to merge 11 commits into
Open
Conversation
It only uses the number of instance names provided, so keep only that and store the selectors in CreationAnalyzer where they are actually used.
That environment variable is set by cvd_internal_start so each run_cvd process knows what instance they are. cvd_internal_start never read it, so `cvd create` shouldn't either.
The StartSelectorParser already duplicates a lot of its logic and ends
up using it only to turn the base and number of instances into the
instance ids vector {base, base+1, ..., base + num - 1}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the simplification is done in StartSelectorParser.
The most significant change is that it no longer considers the
$CUTTLEFISH_INSTANCEenvironment variable when trying to figure the number of instances and its ids.cvd_internal_startnever expected the user to set that variable, expecting the user to use flags instead. That variable is unconditionally set bycvd_internal_startsorun_cvdand its children know which instance they are running.NOTE TO REVIEWER: reviewing each commit separately is going to be a lot easier than the entire PR at once.