From 50cce00bc755ed8b951c7b148bac02fa5f33ee3a Mon Sep 17 00:00:00 2001 From: Shivanee Persaud Date: Tue, 10 Feb 2026 16:06:14 -0800 Subject: [PATCH 1/2] docs: Add parameters to remaining overloads (consolidated PR) --- src/transaction.ts | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/transaction.ts b/src/transaction.ts index 2525b0090..437039bc2 100644 --- a/src/transaction.ts +++ b/src/transaction.ts @@ -131,11 +131,7 @@ class Transaction extends DatastoreRequest { * transaction. * * @param {CallOptions | https://googleapis.github.io/gax-nodejs/global.html#CallOptions} [gaxOptions] Request configuration options. - * @param {function} callback The callback function. - * @param {?error} callback.err An error returned while making this request. - * If the commit fails, we automatically try to rollback the transaction - * (see {module:datastore/transaction#rollback}). - * @param {object} callback.apiResponse The full API response. + * @returns {Promise} The full API response. * * @example * ``` @@ -168,7 +164,15 @@ class Transaction extends DatastoreRequest { * @param {object} callback.apiResponse The full API response. */ commit(callback: CommitCallback): void; + /** + * @param {CallOptions | https://googleapis.github.io/gax-nodejs/global.html#CallOptions} [gaxOptions] Request configuration options. + * @param {CommitCallback} callback The callback function. + */ commit(gaxOptions: CallOptions, callback: CommitCallback): void; + /** + * @param gaxOptionsOrCallback {CallOptions | https://googleapis.github.io/gax-nodejs/global.html#CallOptions} [gaxOptions] Request configuration options. + * @param cb The callback function. + */ commit( gaxOptionsOrCallback?: CallOptions | CommitCallback, cb?: CommitCallback, From 683af758b0d8eb7df377532770a65718c8151f0d Mon Sep 17 00:00:00 2001 From: Shivanee Persaud Date: Tue, 10 Feb 2026 16:55:17 -0800 Subject: [PATCH 2/2] Addressed docs failures. --- src/transaction.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/transaction.ts b/src/transaction.ts index 437039bc2..48eb97d8a 100644 --- a/src/transaction.ts +++ b/src/transaction.ts @@ -155,8 +155,8 @@ class Transaction extends DatastoreRequest { */ commit(gaxOptions?: CallOptions): Promise; /** - * @param {object} [gaxOptions] Request configuration options, outlined here: - * https://googleapis.github.io/gax-nodejs/global.html#CallOptions. + * @param {object} [gaxOptions] Request configuration options. + * See {@link https://googleapis.github.io/gax-nodejs/global.html#CallOptions CallOptions Docs}. * @param {function} callback The callback function. * @param {?error} callback.err An error returned while making this request. * If the commit fails, we automatically try to rollback the transaction @@ -165,12 +165,14 @@ class Transaction extends DatastoreRequest { */ commit(callback: CommitCallback): void; /** - * @param {CallOptions | https://googleapis.github.io/gax-nodejs/global.html#CallOptions} [gaxOptions] Request configuration options. + * @param {CallOptions} [gaxOptions] Request configuration options. + * See {@link https://googleapis.github.io/gax-nodejs/global.html#CallOptions CallOptions Docs}. * @param {CommitCallback} callback The callback function. */ commit(gaxOptions: CallOptions, callback: CommitCallback): void; /** - * @param gaxOptionsOrCallback {CallOptions | https://googleapis.github.io/gax-nodejs/global.html#CallOptions} [gaxOptions] Request configuration options. + * @param {CallOptions} [gaxOptionsOrCallback] Request configuration options. + * See {@link https://googleapis.github.io/gax-nodejs/global.html#CallOptions CallOptions Docs}. * @param cb The callback function. */ commit(