From 3e237da279fd88a41c5d014ab44fb05042d23ee6 Mon Sep 17 00:00:00 2001 From: Timur Olzhabayev Date: Mon, 3 Aug 2026 13:28:47 +0200 Subject: [PATCH] fix(create-plugin): unpin @playwright/test now that 1.62.1 fixes tsconfig resolution --- .github/workflows/ci.yml | 7 ------- packages/create-plugin/templates/common/_package.json | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3a401103e6..d9c7655507 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -210,13 +210,6 @@ jobs: run: npx create-plugin update --force working-directory: ./${{ env.WORKING_DIR }} - # Temporarily pin playwright to match the template: the scaffolded plugin has a caret range - # that resolves to 1.62, which crashes on tsconfigs extending @grafana/tsconfig. - # Remove once playwright ships a fix and the template pin is lifted. - - name: Pin playwright version - run: npm install --no-audit --save-dev @playwright/test@~1.61.1 - working-directory: ./${{ env.WORKING_DIR }} - - name: Lint plugin frontend run: npm run lint working-directory: ./${{ env.WORKING_DIR }} diff --git a/packages/create-plugin/templates/common/_package.json b/packages/create-plugin/templates/common/_package.json index 54dab80766..8ba4bd30df 100644 --- a/packages/create-plugin/templates/common/_package.json +++ b/packages/create-plugin/templates/common/_package.json @@ -20,7 +20,7 @@ "@grafana/plugin-e2e": "^3.10.0", "@grafana/sign-plugin": "^3.3.3", "@grafana/tsconfig": "^2.2.0", - "@playwright/test": "~1.61.1",{{#if useExperimentalRspack}} + "@playwright/test": "^1.62.1",{{#if useExperimentalRspack}} "@rspack/core": "^1.6.0", "@rspack/cli": "^1.6.0",{{/if}} "@stylistic/eslint-plugin-ts": "^4.4.0",