From 90313280d0bd4b153ec304ed24f47c4004ef7d2a Mon Sep 17 00:00:00 2001 From: Et7f3 Date: Sat, 1 Feb 2020 20:28:45 +0100 Subject: [PATCH 1/2] Change MessageEvent to Event like the spec. Source https://html.spec.whatwg.org/multipage/indices.html#event-open --- src/WebsocketClient.re | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/WebsocketClient.re b/src/WebsocketClient.re index a0066e1..f5a6bfe 100644 --- a/src/WebsocketClient.re +++ b/src/WebsocketClient.re @@ -1,3 +1,9 @@ +module /*Open*/Event = { + type t; + + include EventRe.Impl({ type nonrec t = t; }); +}; + module MessageEvent = { type t; type data('a); @@ -70,7 +76,7 @@ module Websocket = { type t('msg) = {. [@bs.set] "binaryType": string, - [@bs.set] "onopen": MessageEvent.t => unit, + [@bs.set] "onopen": Event.t => unit, [@bs.set] "onerror": MessageEvent.t => unit, [@bs.set] "onclose": CloseEvent.t => unit, [@bs.set] "onmessage": MessageEvent.t => unit, From f31cf36ab4bb1882b8a0af7379abf0ed2bab3174 Mon Sep 17 00:00:00 2001 From: Et7f3 Date: Sun, 2 Feb 2020 02:18:17 +0100 Subject: [PATCH 2/2] readyState is `unsigned short` https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/readyState --- src/WebsocketClient.re | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WebsocketClient.re b/src/WebsocketClient.re index f5a6bfe..238aff3 100644 --- a/src/WebsocketClient.re +++ b/src/WebsocketClient.re @@ -83,7 +83,7 @@ module Websocket = { "bufferedAmount": int, "url": string, "protocol": string, - "readyState": string, + "readyState": int, "extensions": string, [@bs.meth] "close": Js.Undefined.t(string) => Js.Undefined.t(string) => unit, [@bs.meth] "send": 'msg => unit