Skip to content

Commit 9a28f7d

Browse files
authored
Merge pull request #295 from graphql-java/use-java-17
Use Java 17
2 parents 82a721b + 34c7001 commit 9a28f7d

2 files changed

Lines changed: 11 additions & 9 deletions

File tree

‎README.md‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
[![Latest Snapshot](https://img.shields.io/maven-central/v/com.graphql-java/java-dataloader?label=maven-central%20snapshot&versionPrefix=0)](https://maven-badges.herokuapp.com/maven-central/com.graphql-java/graphql-java/)
66
[![Apache licensed](https://img.shields.io/hexpm/l/plug.svg?maxAge=2592000)](https://github.com/graphql-java/java-dataloader/blob/master/LICENSE)
77

8-
This small and simple utility library is a pure Java 11 port of [Facebook DataLoader](https://github.com/facebook/dataloader).
8+
This small and simple utility library is a pure Java port of [Facebook DataLoader](https://github.com/facebook/dataloader).
9+
10+
The current development version requires Java 17 or later to run.
911

1012
It can serve as integral part of your application's data layer to provide a
1113
consistent API over various back-ends and reduce message communication overhead through batching and caching.
@@ -16,7 +18,7 @@ are resolved independently and, with a true graph of objects, you may be fetchin
1618
A naive implementation of graphql data fetchers can easily lead to the dreaded "n+1" fetch problem.
1719

1820
Most of the code is ported directly from Facebook's reference implementation, with one IMPORTANT adaptation to make
19-
it work for Java 11. ([more on this below](#manual-dispatching)).
21+
it work for Java. ([more on this below](#manual-dispatching)).
2022

2123
Before reading on, be sure to take a short dive into the
2224
[original documentation](https://github.com/facebook/dataloader/blob/master/README.md) provided by Lee Byron (@leebyron)
@@ -74,7 +76,7 @@ dependencies {
7476

7577
### Building
7678

77-
To build from source use the Gradle wrapper:
79+
Building from source uses a JDK 21 toolchain. Use the Gradle wrapper:
7880

7981
```
8082
./gradlew clean build
@@ -834,10 +836,10 @@ This library was originally written for use within a [VertX world](http://vertx.
834836
itself. All the heavy lifting has been done by this project : [vertx-dataloader](https://github.com/engagingspaces/vertx-dataloader)
835837
including the extensive testing (which itself came from Facebook).
836838

837-
This particular port was done to reduce the dependency on Vertx and to write a pure Java 11 implementation with no dependencies and also
839+
This particular port was done to reduce the dependency on Vertx and to write a pure Java implementation with no dependencies and also
838840
to use the more normative Java CompletableFuture.
839841

840-
[vertx-core](http://vertx.io/docs/vertx-core/java/) is not a lightweight library by any means so having a pure Java 11 implementation is
842+
[vertx-core](http://vertx.io/docs/vertx-core/java/) is not a lightweight library by any means so having a pure Java implementation is
841843
very desirable.
842844

843845

‎build.gradle‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ kotlin {
3232
compilerOptions {
3333
apiVersion = KotlinVersion.KOTLIN_2_0
3434
languageVersion = KotlinVersion.KOTLIN_2_0
35-
jvmTarget = JvmTarget.JVM_11
35+
jvmTarget = JvmTarget.JVM_17
3636
javaParameters = true
3737
freeCompilerArgs = [
3838
'-Xemit-jvm-type-annotations',
@@ -59,7 +59,7 @@ def getDevelopmentVersion() {
5959
def releaseVersion = System.env.RELEASE_VERSION
6060
version = releaseVersion ? releaseVersion : getDevelopmentVersion()
6161
group = 'com.graphql-java'
62-
description = 'A pure Java 11 port of Facebook Dataloader'
62+
description = 'A pure Java 17 port of Facebook Dataloader'
6363

6464
gradle.buildFinished { buildResult ->
6565
println "*******************************"
@@ -108,7 +108,7 @@ dependencies {
108108
}
109109

110110
tasks.withType(JavaCompile) {
111-
options.release = 11
111+
options.release = 17
112112
options.errorprone {
113113
disableAllChecks = true
114114
check("NullAway", CheckSeverity.ERROR)
@@ -187,7 +187,7 @@ publishing {
187187
asNode().children().last() + {
188188
resolveStrategy = Closure.DELEGATE_FIRST
189189
name 'java-dataloader'
190-
description 'A pure Java 11 port of Facebook Dataloader'
190+
description project.description
191191
url 'https://github.com/graphql-java/java-dataloader'
192192
inceptionYear '2017'
193193

0 commit comments

Comments
 (0)