Add product element ID#302
Open
andrewHEguardian wants to merge 1 commit into
Open
Conversation
andrewHEguardian
force-pushed
the
ahe/product-element-uuid
branch
from
be9cd26 to
fab0869
Compare
simonbyford
approved these changes
May 6, 2026
gu-scala-library-release Bot
added a commit
that referenced
this pull request
May 7, 2026
…ished by andrewHEguardian andrewHEguardian published release version 39.0.0-PREVIEW.aheproduct-element-uuid.2026-05-07T0838.fab08696 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 39.0.0-PREVIEW.aheproduct-element-uuid.2026-05-07T0838.fab08696 Release-Initiated-By: https://github.com/andrewHEguardian Release-Workflow-Run: https://github.com/guardian/content-api-models/actions/runs/25485273058 Release-Notes: #302
Contributor
|
@andrewHEguardian has published a preview version of this PR with release workflow run #125, based on commit fab0869: 39.0.0-PREVIEW.aheproduct-element-uuid.2026-05-07T0838.fab08696 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the ahe/product-element-uuid branch, or use the GitHub CLI command: gh workflow run release.yml --ref ahe/product-element-uuid Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
|
|
||
| 10: optional list<BlockElement> content; | ||
|
|
||
| 11: optional string id; |
Member
There was a problem hiding this comment.
I'd suggest a more granular name could be useful here. productId if that's appropriate, or productElementId if that's more accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds an ID field to the product element. We need an ID field per product because we are planning on creating a summary element with a relationship to products. This should also be a future proofing for potentially having a product database later. The field will be populated with a generated UUID.
How has this change been tested?
Deployment chain
How can we measure success?
Have we considered potential risks?
Images
Accessibility