diff --git a/ab-testing/config/abTests.ts b/ab-testing/config/abTests.ts index eabf3b0419f..e63668aa871 100644 --- a/ab-testing/config/abTests.ts +++ b/ab-testing/config/abTests.ts @@ -45,18 +45,6 @@ const ABTests: ABTest[] = [ groups: ["control", "variant"], shouldForceMetricsCollection: true, }, - { - name: "fronts-and-curation-onward-journeys", - description: "Testing the new Onward Journey component on all articles", - owners: ["fronts.and.curation@guardian.co.uk"], - expirationDate: `2026-02-25`, - type: "client", - status: "ON", - audienceSize: 50 / 100, - audienceSpace: "A", - groups: ["control", "variant"], - shouldForceMetricsCollection: false, - }, { name: "fronts-and-curation-personalised-container", description: "Testing the a personalised container component on fronts", diff --git a/dotcom-rendering/src/components/Card/Card.tsx b/dotcom-rendering/src/components/Card/Card.tsx index 3a5cdefd48c..25991bf69b0 100644 --- a/dotcom-rendering/src/components/Card/Card.tsx +++ b/dotcom-rendering/src/components/Card/Card.tsx @@ -159,7 +159,6 @@ export type Props = { headlinePosition?: 'inner' | 'outer'; isStorylines?: boolean; starRatingSize?: RatingSizeType; - isInOnwardsAbTestVariant?: boolean; isInPersonalisationVariant?: boolean; }; @@ -407,7 +406,6 @@ export const Card = ({ subtitleSize = 'small', isStorylines = false, starRatingSize = 'small', - isInOnwardsAbTestVariant, isInPersonalisationVariant, }: Props) => { const hasSublinks = supportingContent && supportingContent.length > 0; @@ -681,12 +679,7 @@ export const Card = ({ */ const getGapSizes = (): GapSizes => { if (isOnwardContent && !isGallerySecondaryOnward) { - if ( - isMoreGalleriesOnwardContent || - // This is untidy. If we implement the gallery-style redesign for onwards content - // in all articles, we can refactor how we determine gap sizes for onwards cards. - isInOnwardsAbTestVariant - ) { + if (isMoreGalleriesOnwardContent) { return { row: 'small', column: 'small', @@ -1241,7 +1234,6 @@ export const Card = ({ isBetaContainer, isOnwardContent, )} - isInOnwardsAbTestVariant={!!isInOnwardsAbTestVariant} > {/* In the storylines section on tag pages, the flex splash is used to display key stories. We don't display an article headline in the conventional sense, the key stories are instead displayed as "supporting content". diff --git a/dotcom-rendering/src/components/Card/components/ContentWrapper.tsx b/dotcom-rendering/src/components/Card/components/ContentWrapper.tsx index 96034e61b89..c7f5ff5eca1 100644 --- a/dotcom-rendering/src/components/Card/components/ContentWrapper.tsx +++ b/dotcom-rendering/src/components/Card/components/ContentWrapper.tsx @@ -149,7 +149,6 @@ type Props = { isBetaContainer: boolean; mediaPositionOnDesktop: MediaPositionType; mediaPositionOnMobile: MediaPositionType; - isInOnwardsAbTestVariant: boolean; padContent?: 'small' | 'large'; }; @@ -160,7 +159,6 @@ export const ContentWrapper = ({ isBetaContainer, mediaPositionOnDesktop, mediaPositionOnMobile, - isInOnwardsAbTestVariant, padContent, }: Props) => { const mediaDirectionDesktop = getMediaDirection(mediaPositionOnDesktop); @@ -178,7 +176,6 @@ export const ContentWrapper = ({ }), padContent && !isBetaContainer && - !isInOnwardsAbTestVariant && css` padding: ${space[paddingSpace]}px; `, diff --git a/dotcom-rendering/src/components/FetchOnwardsData.importable.tsx b/dotcom-rendering/src/components/FetchOnwardsData.importable.tsx index af6c1cc352a..9c20935f1f1 100644 --- a/dotcom-rendering/src/components/FetchOnwardsData.importable.tsx +++ b/dotcom-rendering/src/components/FetchOnwardsData.importable.tsx @@ -18,7 +18,6 @@ import type { OnwardsSource } from '../types/onwards'; import type { RenderingTarget } from '../types/renderingTarget'; import type { FETrailType, TrailType } from '../types/trails'; import { Carousel } from './Carousel.importable'; -import { MoreGalleriesStyleOnwardsContent } from './MoreGalleriesStyleOnwardsContent.importable'; import { Placeholder } from './Placeholder'; import { ScrollableSmallOnwards } from './ScrollableSmallOnwards'; @@ -32,7 +31,6 @@ type Props = { renderingTarget: RenderingTarget; isAdFreeUser: boolean; containerPosition: string; - isInOnwardsAbTestVariant?: boolean; webURL: string; }; @@ -82,7 +80,6 @@ export const FetchOnwardsData = ({ renderingTarget, isAdFreeUser, containerPosition, - isInOnwardsAbTestVariant, webURL, }: Props) => { const [hasBeenSeen, setIsInViewRef] = useIsInView({ rootMargin: `-100px` }); @@ -165,16 +162,6 @@ export const FetchOnwardsData = ({ onwardsSource={onwardsSource} format={format} /> - ) : isInOnwardsAbTestVariant ? ( - ) : ( { - const defaultProps: CardProps = { - aspectRatio: '5:4', - avatarUrl: trail.avatarUrl, - branding: trail.branding, - dataLinkName: `onwards-content-gallery-style ${trail.dataLinkName}`, - discussionApiUrl: '', - discussionId: trail.discussion?.isCommentable - ? trail.discussion.discussionId - : undefined, - format: trail.format, - headlineText: trail.headline, - image: trail.image, - imageLoading: 'lazy', - isExternalLink: false, - isInOnwardsAbTestVariant: true, - isOnwardContent: true, - linkTo: trail.url, - mainMedia: trail.mainMedia, - onwardsSource: 'related-content', - showAge: false, - showByline: trail.showByline, - showClock: false, - showPulsingDot: false, - showQuotedHeadline: trail.format.design === ArticleDesign.Comment, - showTopBarDesktop: false, - showTopBarMobile: true, - snapData: trail.snapData, - starRating: trail.starRating, - webPublicationDate: trail.webPublicationDate, - }; - - return defaultProps; -}; - -type Props = { - heading: string; - trails: TrailType[]; - isAdFreeUser: boolean; - discussionApiUrl: string; -}; - -/** - * We are running an AB test to use the More Galleries style of onwards content on all articles. - * If the test is successful, the plan is that this component will be removed and MoreGalleries.tsx will - * be generalised so that is can be used for onwards content across all articles. If the - * test is not successful, this component will be removed. - */ -export const MoreGalleriesStyleOnwardsContent = ({ - heading, - trails, - discussionApiUrl, -}: Props) => { - const [firstTrail, ...standardTrails] = trails; - if (!firstTrail) return null; - - return ( -
- -

{heading}

-
-

{heading}

-
-
- -
- -
    - {standardTrails.slice(0, 4).map((trail: TrailType) => ( -
  • - -
  • - ))} -
-
-
- ); -}; diff --git a/dotcom-rendering/src/components/OnwardsUpper.importable.tsx b/dotcom-rendering/src/components/OnwardsUpper.importable.tsx index 3467fbcbd5d..929b633bc5c 100644 --- a/dotcom-rendering/src/components/OnwardsUpper.importable.tsx +++ b/dotcom-rendering/src/components/OnwardsUpper.importable.tsx @@ -7,7 +7,6 @@ import { Pillar, } from '../lib/articleFormat'; import type { EditionId } from '../lib/edition'; -import { useBetaAB } from '../lib/useAB'; import { useIsHorizontalScrollingSupported } from '../lib/useIsHorizontalScrollingSupported'; import { palette } from '../palette'; import type { OnwardsSource } from '../types/onwards'; @@ -225,14 +224,6 @@ export const OnwardsUpper = ({ renderingTarget, webURL, }: Props) => { - const abTests = useBetaAB(); - const isInOnwardsAbTestVariant = - renderingTarget === 'Web' && - abTests?.isUserInTestGroup( - 'fronts-and-curation-onward-journeys', - 'variant', - ); - const isHorizontalScrollingSupported = useIsHorizontalScrollingSupported(); if (!isHorizontalScrollingSupported) return null; @@ -347,7 +338,6 @@ export const OnwardsUpper = ({ renderingTarget={renderingTarget} isAdFreeUser={isAdFreeUser} containerPosition="first" - isInOnwardsAbTestVariant={isInOnwardsAbTestVariant} webURL={webURL} />