From c2d8cd5d75cc65840150f823d81e4a4e721a908f Mon Sep 17 00:00:00 2001 From: Yvette Carlisle Date: Thu, 11 Jun 2026 10:45:12 +0800 Subject: [PATCH 1/3] {"schema":"decodex/commit/1","summary":"Document no-compat review config release gate","authority":"XY-908"} --- docs/runbook/release-readiness.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/runbook/release-readiness.md b/docs/runbook/release-readiness.md index 1d6b06237..c207dd7d5 100644 --- a/docs/runbook/release-readiness.md +++ b/docs/runbook/release-readiness.md @@ -38,7 +38,9 @@ Collect evidence in this order: ``` 3. Scan checked-in docs, skills, examples, and config templates for historical review - config fields. The literal old field names may appear only in migration history. + config fields. The literal old field names `internal_review_mode` and + `external_review_enabled` may appear only in migration history, and they must not + appear in active project configs, examples, templates, or release procedures. 4. Run the registered project gate before any pushed PR head. This mirrors the registered `WORKFLOW.md` order: canonicalize first, then verify. @@ -58,7 +60,10 @@ Collect evidence in this order: 7. Run focused loop, review, config, prompt, dry-run, and recovery checks selected from the landed dependency changes. At minimum include review-level and config - coverage: + coverage. Text search from step 3 is not sufficient: the release evidence must + show the active project config parser rejects `internal_review_mode` and + `external_review_enabled`, while the current `[codex].review` model remains + covered by review/config tests. ```sh cargo test -p decodex review --all-features -- --test-threads=1 From e6d20a8f64435b0a0b666ad9d5fcab0b8f7def60 Mon Sep 17 00:00:00 2001 From: Yvette Carlisle Date: Thu, 11 Jun 2026 10:52:51 +0800 Subject: [PATCH 2/3] {"schema":"decodex/commit/1","summary":"Clarify release gate legacy-key scan scope","authority":"XY-908"} --- docs/runbook/release-readiness.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/runbook/release-readiness.md b/docs/runbook/release-readiness.md index c207dd7d5..d5d2ebbe1 100644 --- a/docs/runbook/release-readiness.md +++ b/docs/runbook/release-readiness.md @@ -38,9 +38,10 @@ Collect evidence in this order: ``` 3. Scan checked-in docs, skills, examples, and config templates for historical review - config fields. The literal old field names `internal_review_mode` and - `external_review_enabled` may appear only in migration history, and they must not - appear in active project configs, examples, templates, or release procedures. + config fields. Because this gate names the removed keys to define the check, allow + `internal_review_mode` and `external_review_enabled` here and in migration history + only. They must not appear in active project configs, examples, templates, or other + release procedures. 4. Run the registered project gate before any pushed PR head. This mirrors the registered `WORKFLOW.md` order: canonicalize first, then verify. From e0223bff389b15f5d3e212480b25a271ad0498dd Mon Sep 17 00:00:00 2001 From: Yvette Carlisle Date: Thu, 11 Jun 2026 11:00:56 +0800 Subject: [PATCH 3/3] {"schema":"decodex/commit/1","summary":"Narrow legacy-key gate exception","authority":"XY-908"} --- docs/runbook/release-readiness.md | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/runbook/release-readiness.md b/docs/runbook/release-readiness.md index d5d2ebbe1..c90b7e4bf 100644 --- a/docs/runbook/release-readiness.md +++ b/docs/runbook/release-readiness.md @@ -38,10 +38,10 @@ Collect evidence in this order: ``` 3. Scan checked-in docs, skills, examples, and config templates for historical review - config fields. Because this gate names the removed keys to define the check, allow - `internal_review_mode` and `external_review_enabled` here and in migration history - only. They must not appear in active project configs, examples, templates, or other - release procedures. + config fields. Because this bullet names the removed keys to define the check, + allow `internal_review_mode` and `external_review_enabled` in this bullet and in + migration history only. They must not appear in active project configs, examples, + templates, or other release procedures. 4. Run the registered project gate before any pushed PR head. This mirrors the registered `WORKFLOW.md` order: canonicalize first, then verify. @@ -62,9 +62,8 @@ Collect evidence in this order: 7. Run focused loop, review, config, prompt, dry-run, and recovery checks selected from the landed dependency changes. At minimum include review-level and config coverage. Text search from step 3 is not sufficient: the release evidence must - show the active project config parser rejects `internal_review_mode` and - `external_review_enabled`, while the current `[codex].review` model remains - covered by review/config tests. + show the active project config parser rejects those removed fields, while the + current `[codex].review` model remains covered by review/config tests. ```sh cargo test -p decodex review --all-features -- --test-threads=1