Skip to content

Specify behavior of setting "incompatible" Features in a Target #1164

Description

@steven-johnson

If you set an "incompatible" Feature on a Target, it's not clear that the resulting behavior is well-defined. For instance, say I try to compile using a Target of "arm-64-android-avx" -- what behavior should we expect? Among them:

(1) Should Target::from_string()/merge_string() detect impossible combinations and return false, or just quietly assemble the resulting Target?
(2) Should attempting to compile/JIT/etc with such a Target fail outright, or just quietly ignore inappropriate features?

AFAICT, both of these take the "else" case above; if that's explicitly desired, we should document and test that behavior.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions