From e51b188344abc97e192c3658137f85d58fa90d67 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20Hamb=C3=BCchen?= Date: Thu, 30 Jul 2026 00:19:54 +0000 Subject: [PATCH] Fix `--keep-temp-files` given to Cabal lib versions that don't have it. `Cabal < 3.13` did not support this flag (it did for `... haddock` but not `... repl`). So `Setup.hs` compiled with such older versions rejects it. This causes errors for users of `haskell-language-server` if they have a custom `Setup.hs` depending on `Cabal < 3.13`, because it makes `hie-bios` pass the nonexistent flag, causing error: unrecognized 'repl' option `--keep-temp-files' Error: [Cabal-7125] repl failed for my-package-0.1.0.0. `filterCommonFlags` already removes the flag for `lib:Cabal < 3.13`. --- cabal-install/src/Distribution/Client/Setup.hs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/cabal-install/src/Distribution/Client/Setup.hs b/cabal-install/src/Distribution/Client/Setup.hs index 3acbd6b8f0c..93b9ef82069 100644 --- a/cabal-install/src/Distribution/Client/Setup.hs +++ b/cabal-install/src/Distribution/Client/Setup.hs @@ -1264,10 +1264,7 @@ filterReplFlags :: ReplFlags -> Version -> ReplFlags filterReplFlags flags cabalLibVersion = flags { replCommonFlags = - (filterCommonFlags (replCommonFlags flags) cabalLibVersion) - { -- `cabal repl` knew about `--keep-temp-files` before other commands did. - setupKeepTempFiles = setupKeepTempFiles (replCommonFlags flags) - } + filterCommonFlags (replCommonFlags flags) cabalLibVersion } -- ------------------------------------------------------------