Skip to content

Commit 1d6e925

Browse files
committed
Refactor cookie field name
1 parent f9289da commit 1d6e925

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

loading_api_wrapper/api.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919

2020
class LoadingApiWrapper:
2121
def __init__(self, email=None, password=None):
22-
self.cookies = None
22+
self._cookies = None
2323

2424
if email and password:
2525
response = self._authenticate(email, password)
2626

2727
if response.get("code") == 200:
28-
self.cookies = response.get("cookies")
28+
self._cookies = response.get("cookies")
2929

3030
def _authenticate(self, email, password):
3131
url = f"{API_URL}/{API_VERSION}/auth/login"
@@ -70,7 +70,7 @@ def get_profile(self):
7070
headers = {
7171
"User-Agent": USER_AGENT,
7272
}
73-
response = requests.get(url, headers=headers, cookies=self.cookies)
73+
response = requests.get(url, headers=headers, cookies=self._cookies)
7474

7575
if response.status_code == 200:
7676
return {

tests/test_loading_api_wrapper.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def test_authenticate_success(self, mock_requests):
2323

2424
api = LoadingApiWrapper("test@email.com", "password")
2525

26-
self.assertEqual(api.cookies, self.cookie_jar)
26+
self.assertEqual(api._cookies, self.cookie_jar)
2727

2828
api = LoadingApiWrapper()
2929
response = api._authenticate("test@email.com", "password")
@@ -46,7 +46,7 @@ def test_authenticate_failure_incorrect_email_or_password(self, mock_requests):
4646

4747
api = LoadingApiWrapper("incorrect@email.com", "incorrect_password")
4848

49-
self.assertIsNone(api.cookies)
49+
self.assertIsNone(api._cookies)
5050

5151
api = LoadingApiWrapper()
5252
response = api._authenticate("incorrect@email.com", "incorrect_password")
@@ -78,7 +78,7 @@ def test_authenticate_failure_invalid_email(self, mock_requests):
7878

7979
api = LoadingApiWrapper("invalid_email_address", "password")
8080

81-
self.assertIsNone(api.cookies)
81+
self.assertIsNone(api._cookies)
8282

8383
api = LoadingApiWrapper()
8484
response = api._authenticate("invalid_email_address", "password")
@@ -119,7 +119,7 @@ def test_authenticate_failure_empty_values(self, mock_requests):
119119

120120
api = LoadingApiWrapper("", "")
121121

122-
self.assertIsNone(api.cookies)
122+
self.assertIsNone(api._cookies)
123123

124124
api = LoadingApiWrapper()
125125
response = api._authenticate("", "")
@@ -149,8 +149,8 @@ def test_get_profile_success(self, mock_requests, mock_authenticate):
149149
api = LoadingApiWrapper("test@email.com", "password")
150150
response = api.get_profile()
151151

152-
self.assertIsNotNone(api.cookies)
153-
self.assertEqual(api.cookies, self.cookie_jar)
152+
self.assertIsNotNone(api._cookies)
153+
self.assertEqual(api._cookies, self.cookie_jar)
154154
self.assertEqual(response.get("code"), 200)
155155
self.assertDictEqual(response.get("profile"), expected_response)
156156

@@ -168,7 +168,7 @@ def test_get_profile_failure(self, mock_requests):
168168
api = LoadingApiWrapper()
169169
response = api.get_profile()
170170

171-
self.assertIsNone(api.cookies)
171+
self.assertIsNone(api._cookies)
172172
self.assertEqual(response.get("code"), 401)
173173
self.assertEqual(response.get("message"), "No auth token")
174174

0 commit comments

Comments
 (0)