From 8ef091cfd56c309ee7d23167d041b442b20b40d7 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 30 Jul 2026 22:21:29 +0000 Subject: [PATCH] ci: pin Windows jobs to the windows-2022 runner The windows-latest image no longer ships Visual Studio 2022; it now provides Visual Studio 18 (VSINSTALLDIR .../Visual Studio/18/Enterprise, VisualStudioVersion 18.0). Every Windows job in this workflow configures CMake with -G "Visual Studio 17 2022", so they all fail at configure time: CMake Error at CMakeLists.txt:2 (project): Generator Visual Studio 17 2022 could not find any instance of Visual Studio. Nothing in the repository changed -- this workflow is byte-identical to the last commit whose CI was fully green -- so pin the Windows matrix entries to windows-2022, which still provides the toolchain the generator asks for. This restores exactly the configuration that was last green. Only ci.yml hardcodes the generator; vcpkg.yml and conan.yml let CMake pick one and their Windows jobs still pass on windows-latest, so they are left alone. Follow-up: adopt Visual Studio 18 on windows-latest so this does not need revisiting when windows-2022 is retired. That is a separate change since it builds against a toolchain these projects have not been tested with. --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b4addfd..471bd4e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: # Windows builds - { name: "Windows MSVC Debug", - os: windows-latest, + os: windows-2022, cc: "cl", cxx: "cl", build_type: "Debug", @@ -25,7 +25,7 @@ jobs: } - { name: "Windows MSVC Release", - os: windows-latest, + os: windows-2022, cc: "cl", cxx: "cl", build_type: "Release", @@ -33,7 +33,7 @@ jobs: } - { name: "Windows Clang Debug", - os: windows-latest, + os: windows-2022, cc: "clang", cxx: "clang++", build_type: "Debug", @@ -41,7 +41,7 @@ jobs: } - { name: "Windows Clang Release", - os: windows-latest, + os: windows-2022, cc: "clang", cxx: "clang++", build_type: "Release",