From d5a7b2d8d55791b2c6ea023bfc13319fa1ae6402 Mon Sep 17 00:00:00 2001 From: ddevin96 Date: Wed, 11 Mar 2026 11:32:11 +0100 Subject: [PATCH 1/3] feat: pr template --- .../pull_request_template.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md new file mode 100644 index 0000000..dc0425d --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -0,0 +1,17 @@ + All Submissions: + +* [ ] Have you followed the guidelines in our Contributing document? +* [ ] Have you checked to ensure there aren't other open [Pull Requests](../../../pulls) for the same update/change? + + + +### New Feature Submissions: + +1. [ ] Does your submission pass tests? +2. [ ] Have you lint your code locally before submission? + +### Changes to Core Features: + +* [ ] Have you added an explanation of what your changes do and why you'd like us to include them? +* [ ] Have you written new tests for your core changes, as applicable? +* [ ] Have you successfully run tests with your changes locally? From 49da80f7d1ac18b7ca520233d6a4788745966b47 Mon Sep 17 00:00:00 2001 From: ddevin96 Date: Wed, 11 Mar 2026 15:09:49 +0100 Subject: [PATCH 2/3] feat: resolved style comments for template --- .../PULL_REQUEST_TEMPLATE/pull_request_template.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index dc0425d..41dc3b6 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,17 +1,20 @@ All Submissions: -* [ ] Have you followed the guidelines in our Contributing document? +* [ ] Have you followed the guidelines in our [Contributing](../../CONTRIBUTING.md) document? * [ ] Have you checked to ensure there aren't other open [Pull Requests](../../../pulls) for the same update/change? -### New Feature Submissions: +### Checklist: -1. [ ] Does your submission pass tests? -2. [ ] Have you lint your code locally before submission? +1. [x] Does your submission pass tests? (use make test) +2. [x] Have you lint your code locally before submission? (use make lint) +3. [x] Have you type checked your code locally before submission? (use make typecheck) ### Changes to Core Features: * [ ] Have you added an explanation of what your changes do and why you'd like us to include them? -* [ ] Have you written new tests for your core changes, as applicable? +* [ ] Have you written tests to cover all your changes? If not, why? + + * [ ] Have you successfully run tests with your changes locally? From c2e203abc1c4dfd8b2ee92233a794201e0799c4d Mon Sep 17 00:00:00 2001 From: ddevin96 Date: Wed, 11 Mar 2026 15:53:18 +0100 Subject: [PATCH 3/3] feat: resolve comment for pr style --- .../pull_request_template.md | 20 +++++++------------ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 41dc3b6..44f208a 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,20 +1,14 @@ - All Submissions: +### All Submissions * [ ] Have you followed the guidelines in our [Contributing](../../CONTRIBUTING.md) document? * [ ] Have you checked to ensure there aren't other open [Pull Requests](../../../pulls) for the same update/change? -### Checklist: +### Checklist -1. [x] Does your submission pass tests? (use make test) -2. [x] Have you lint your code locally before submission? (use make lint) -3. [x] Have you type checked your code locally before submission? (use make typecheck) - -### Changes to Core Features: - -* [ ] Have you added an explanation of what your changes do and why you'd like us to include them? -* [ ] Have you written tests to cover all your changes? If not, why? - - -* [ ] Have you successfully run tests with your changes locally? +1. [ ] Does your submission pass all tests? (use `make test`) +2. [ ] Have you written tests to cover all your changes? If not, provide a reason. +3. [ ] Have you lint your code locally before submission? (use `make lint`) +4. [ ] Have you type checked your code locally before submission? (use `make typecheck`) +5. [ ] Have you added an explanation of what your changes are and why you'd like us to include them?