setup gocd pipeline

Author: mpantel

hyperstack.gocd.yaml

@@ -16,27 +16,27 @@ pipelines:
         auto_update: true
         branch: edge
     stages:
-#      - cleanup1:
-#          fetch_materials: true
-#          keep_artifacts: false
-#          clean_workspace: false
-#          approval:
-#            type: success
-#            allow_only_on_success: false
-#          jobs:
-#            cleanup:
-#              timeout: 0
-#              tasks:
-#                - exec:
-#                    arguments:
-#                      - compose
-#                      - run
-#                      - --rm
-#                      - --entrypoint
-#                      - "/bin/bash -c 'chown -R 1000:1001 /root/hyperstack'"
-#                      - hyperstack
-#                    command: docker
-#                    run_if: passed
+      - cleanup1:
+          fetch_materials: true
+          keep_artifacts: false
+          clean_workspace: false
+          approval:
+            type: success
+            allow_only_on_success: false
+          jobs:
+            cleanup:
+              timeout: 0
+              tasks:
+                - exec:
+                    arguments:
+                      - compose
+                      - run
+                      - --rm
+                      - --entrypoint
+                      - "/bin/bash -c 'chown -R 1000:1001 /root/hyperstack'"
+                      - hyperstack
+                    command: docker
+                    run_if: passed
       - execute:
           fetch_materials: true
           keep_artifacts: false

ruby/hyper-component/.travis.yml

@@ -21,6 +21,8 @@ before_script:
   - bundle install --jobs=3 --retry=3
   - bundle exec rails db:setup
   - cd ../../
+  - if [[ "$DRIVER" == "google-chrome" ]]; then bundle exec chromedriver-update; fi
+  - if [[ "$DRIVER" == "google-chrome" ]]; then ls -lR ~/.chromedriver-helper/; fi
   - if [[ "$DRIVER" == "google-chrome" ]]; then bundle exec chromedriver --version; fi
   - if [[ "$DRIVER" == "google-chrome" ]]; then google-chrome --version; fi
   - if [[ "$DRIVER" == "google-chrome" ]]; then which google-chrome; fi

ruby/hyper-component/Gemfile

@@ -4,9 +4,9 @@ gem 'hyper-spec',        path: '../hyper-spec'
 gem 'hyperstack-config', path: '../hyperstack-config'
 gem 'hyper-store',       path: '../hyper-store'
 gem 'hyper-state',       path: '../hyper-state'
-unless ENV['OPAL_VERSION']&.match("0.11")
-  gem 'opal-browser', git: 'https://github.com/opal/opal-browser'
-end
+# unless ENV['OPAL_VERSION']&.match("0.11")
+#   gem 'opal-browser', git: 'https://github.com/opal/opal-browser'
+# end
 gem 'hyper-trace',       path: '../hyper-trace'
 
 #gem 'puma', '~> 3.11.0' # As of adding, version 3.12.0 isn't working so we are locking

ruby/hyper-component/hyper-component.gemspec

@@ -20,25 +20,26 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'hyper-state', Hyperstack::Component::VERSION
   spec.add_dependency 'hyperstack-config', Hyperstack::Component::VERSION
   spec.add_dependency 'opal-activesupport', '~> 0.3.1'
-  spec.add_dependency 'react-rails', '>= 2.4.0', '< 2.7.0'
+  spec.add_dependency 'react-rails', '>= 2.4.0', '< 2.5.0'
 
   spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'chromedriver-helper'
   spec.add_development_dependency 'hyper-spec', Hyperstack::Component::VERSION
   spec.add_development_dependency 'jquery-rails'
   spec.add_development_dependency 'listen'
   spec.add_development_dependency 'mime-types'
-  spec.add_development_dependency 'mini_racer'#, '< 0.4.0' # something is busted with 0.4.0 and its libv8-node dependency
+  spec.add_development_dependency 'mini_racer', '< 0.4.0' # something is busted with 0.4.0 and its libv8-node dependency
   spec.add_development_dependency 'nokogiri'
   spec.add_development_dependency 'opal-jquery'
-  spec.add_development_dependency 'opal-rails', '>= 0.9.4', '< 2.0'
+  spec.add_development_dependency 'opal-rails'
   spec.add_development_dependency 'pry-rescue'
   spec.add_development_dependency 'pry-stack_explorer'
-  spec.add_development_dependency 'puma'
+  spec.add_development_dependency 'puma', '<= 5.4.0'
   spec.add_development_dependency 'rails', ENV['RAILS_VERSION'] || '>= 5.0.0', '< 7.0'
   spec.add_development_dependency 'rails-controller-testing'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec-rails'
   spec.add_development_dependency 'rubocop' #, '~> 0.51.0'
   spec.add_development_dependency 'sqlite3', '~> 1.4.2'
-  spec.add_development_dependency 'timecop'#, '~> 0.8.1'
+  spec.add_development_dependency 'timecop', '~> 0.8.1'
 end

ruby/hyper-component/lib/hyperstack/component/version.rb

@@ -1,5 +1,5 @@
 module Hyperstack
   module Component
-    VERSION = '1.0.alpha1.8.0009' # '1.0.alpha1.5'
+    VERSION = '1.0.alpha1.8.0010' # '1.0.alpha1.5'
   end
 end

ruby/hyper-component/lib/hyperstack/internal/component/props_wrapper.rb

@@ -110,9 +110,9 @@ def [](prop)
         def fetch_from_cache(name, param_type, props)
           last, cached_value = cache[name]
           return cached_value if last.equal?(props[name])
-          value = convert_param(name, param_type, props)
-          cache[name] = [props[name], value]
-          return value
+          convert_param(name, param_type, props).tap do |value|
+            cache[name] = [props[name], value]
+          end
         end
 
         def convert_param(name, param_type, props)

ruby/hyper-component/lib/hyperstack/internal/component/react_wrapper.rb

@@ -32,10 +32,11 @@ def self.import_native_component(opal_class, native_class)
         def self.eval_native_react_component(name)
           component = `eval(name)`
           raise "#{name} is not defined" if `#{component} === undefined`
+
           component = `component.default` if `component.__esModule && component.default`
           is_component_class = `#{component}.prototype !== undefined` &&
-            (`!!#{component}.prototype.isReactComponent` ||
-              `!!#{component}.prototype.render`)
+                                (`!!#{component}.prototype.isReactComponent` ||
+                                 `!!#{component}.prototype.render`)
           is_memo = `#{component}.type != undefined` && `typeof #{component}.type.render === "function"`
           has_render_method = `typeof #{component}.render === "function"`
           unless is_component_class || stateless?(component) || has_render_method || is_memo

ruby/hyper-component/spec/active_support_spec.rb

@@ -18,6 +18,7 @@ def payments
         GenericEnumerable.new([ Payment.new(5), Payment.new(15), Payment.new(10) ])
       end
     end
+
     expect_evaluate_ruby do
       { Payment.new(5) => 5, Payment.new(15) => 15, Payment.new(10) => 10 } == payments.index_with(&:price)
     end.to be_truthy

ruby/hyper-component/spec/client_features/component_spec.rb

@@ -542,7 +542,7 @@ class Lorem; end
           end
           Hyperstack::Component::ReactTestUtils.render_component_into_document(Foo, bar: 10, lorem: Lorem.new)
         end
-        expect(page.driver.browser.manage.logs.get(:browser).map { |m| m.message.gsub(/\\n/, "\n") }.to_a.join("\n"))
+        expect(page.driver.browser.logs.get(:browser).map { |m| m.message.gsub(/\\n/, "\n") }.to_a.join("\n"))
           .to match(/Warning: Failed prop( type|Type): In component `Foo`\nRequired prop `foo` was not specified\nProvided prop `bar` could not be converted to String/)
       end
 
@@ -560,7 +560,7 @@ class Lorem; end
           end
           Hyperstack::Component::ReactTestUtils.render_component_into_document(Foo, foo: 10, bar: '10', lorem: Lorem.new)
         end
-        expect(page.driver.browser.manage.logs.get(:browser).map { |m| m.message.gsub(/\\n/, "\n") }.to_a.join("\n")).to_not match(/prop/)
+        expect(page.driver.browser.logs.get(:browser).map { |m| m.message.gsub(/\\n/, "\n") }.to_a.join("\n")).to_not match(/prop/)
       end
     end
 
@@ -597,7 +597,7 @@ class Foo
 
         Hyperstack::Component::ReactTestUtils.render_component_into_document(foo)
       end
-      expect(page.driver.browser.manage.logs.get(:browser)
+      expect(page.driver.browser.logs.get(:browser)
         .reject { |entry| entry.to_s.include?('Deprecated feature') }
         .reject { |entry| entry.to_s.include?('Object freezing is not supported by Opal')}
         .map { |m| m.message.gsub(/\\n/, "\n") }.to_a.join("\n").size)
@@ -612,7 +612,7 @@ class Foo < Hyperloop::Component
           render { Foo }
         end
       end
-      expect(page.driver.browser.manage.logs.get(:browser).map { |m| m.message.gsub(/\\n/, "\n") }.to_a.join("\n"))
+      expect(page.driver.browser.logs.get(:browser).map { |m| m.message.gsub(/\\n/, "\n") }.to_a.join("\n"))
         .to match(/did you mean to say Foo()/)
     end
   end

ruby/hyper-component/spec/client_features/dsl_spec.rb

@@ -182,7 +182,7 @@ class NestedComp < Hyperloop::Component
         class Comp; end
       end
     end
-    expect(page.driver.browser.manage.logs.get(:browser).map { |m| m.message.gsub(/\\n/, "\n") }.to_a.join("\n"))
+    expect(page.driver.browser.logs.get(:browser).map { |m| m.message.gsub(/\\n/, "\n") }.to_a.join("\n"))
           .to match(/Comp does not appear to be a react component./)
   end