Skip to content

PR for XEP-0454 Media File Sharing#680

Open
cmeng-git wants to merge 4 commits into
igniterealtime:masterfrom
cmeng-git:PR_XEP_0454
Open

PR for XEP-0454 Media File Sharing#680
cmeng-git wants to merge 4 commits into
igniterealtime:masterfrom
cmeng-git:PR_XEP_0454

Conversation

@cmeng-git

Copy link
Copy Markdown
Contributor

Replaces: #317 pull request with the following updates

  • Remove RandomUtils.java #secureRandomBytes() class and use RandomUtil#fillWithSecureRandom(key);
  • Move StringUtils.hexStringToByteArray() into AesgcmUrl.class; eliminating patched StringUtils
  • Update all project files with XEP-XXXX to XEP-0454: OMEMO Media Sharing

@cmeng-git cmeng-git changed the base branch from master to 4.4 October 7, 2025 02:57
@stokito

stokito commented Oct 7, 2025

Copy link
Copy Markdown
Member

Thank you!

Replaces: #317 pull request

The text in a commit message is not really needed for a history.

You can add Co-authored-by: Paul Schaub <vanitasvitae@fsfe.org> to show him as an author too.

The PR is opened not into the current master branch but into the igniterealtime:4.4. I see the difference that the ‎documentation/extensions/index.md file is now removed and instead we should add the new supported XEP into the doap.xml.

@cmeng-git

Copy link
Copy Markdown
Contributor Author

Where should I add this?

You can add Co-authored-by: Paul Schaub vanitasvitae@fsfe.org to show him as an author too.

The PR is raised against igniterealtime:4.4 as the libraray is only tested in this version. I can change to master assume it works with master library.

Where is doap.xml? I can only locate resources/smack.doap file.

@cmeng-git cmeng-git changed the base branch from 4.4 to master December 19, 2025 00:56

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants