columnAt, groupBy: skip scalar rows in mixed data like indexBy does

Mixed data (some rows, some scalars) passes assertNestedArray(), which only requires one nested value. columnAt() then threw a TypeError from count() on the scalar, and groupBy() grouped scalars under the '' key. indexBy() already skips scalar rows; now all three agree. Tests pin the skip in both modes.

Also in Deprecations.php docblocks: fold sprintf()'s asRaw() note into its example comment, and move offsetSet()'s note above the @deprecated tag.

Author: daveedis

src/Deprecations.php

@@ -165,13 +165,12 @@ public function each(Closure $callback): static
      *     $list->sprintf('<li>{value}</li>')->implode("\n");
      *     $list->map(fn($v) => "<li>$v</li>")->implode("\n");
      *
-     *     // SmartArrayHtml (HTML-encoded), old and new:
+     *     // SmartArrayHtml (HTML-encoded), old and new. asRaw() matters here:
+     *     // without it, implode() returns a SmartString that would re-encode
+     *     // the HTML tags at output.
      *     $row->sprintf('<td>{value}</td>')->implode("\n");
      *     $row->asRaw()->map(fn($v) => "<td>" . htmlspecialchars((string)$v) . "</td>")->implode("\n"); // or h() in CMS Builder
      *
-     * The asRaw() in the HTML-mode replacement matters: without it, implode()
-     * returns a SmartString that would re-encode the HTML tags at output.
-     *
      * @param string $format sprintf format string (supports {value}/{key} aliases)
      * @return SmartArray Pre-formatted strings that won't be re-encoded on output
      * @throws InvalidArgumentException If called on a nested array
@@ -404,11 +403,10 @@ public function chunk(int $size): static
     /**
      * Sets a value in the SmartArray using array syntax.
      *
-     * @deprecated Use ->key = $value or ->{'key'} = $value instead of $array['key'] = $value
-     *
      * Note: If you add a key after the array is created the position properties will not be updated.
      * If needed you can recreate the array like this: $newArray = SmartArray::new($oldArray->toArray());
      *
+     * @deprecated Use ->key = $value or ->{'key'} = $value instead of $array['key'] = $value
      * @param mixed $offset The key to set. If null, the value is appended to the array.
      * @param mixed $value The value to set. Will be converted to SmartString or SmartArray as appropriate.
      *

src/SmartArrayBase.php

@@ -724,6 +724,9 @@ public function groupBy(string $field): static
 
         $values = [];
         foreach ($this->toArray() as $row) {
+            if (!is_array($row)) {
+                continue; // scalar rows have no fields to group by
+            }
             $key            = $row[$field] ?? null;
             $values[$key][] = $row;
         }
@@ -755,6 +758,9 @@ public function columnAt(int $index): static
 
         $values = [];
         foreach ($this->toArray() as $row) {
+            if (!is_array($row)) {
+                continue; // scalar rows have no columns to extract
+            }
             $count    = count($row);
             $rowIndex = ($index < 0) ? $count + $index : $index; // Convert negative indexes to positive
 

tests/Unit/ProjectionTest.php

@@ -118,6 +118,15 @@ public function testPluckNthOnFlatThrows(string $class): void
         $class::new(['a', 'b'])->pluckNth(0);
     }
 
+    #[DataProvider('modeProvider')]
+    public function testColumnAtSkipsScalarRows(string $class): void
+    {
+        // One array value makes the array "nested"; scalar rows have no columns to extract
+        $sa = $class::new([['a', 'b'], 'scalar', ['c', 'd']]);
+
+        $this->assertSame(['a', 'c'], $sa->columnAt(0)->toArray());
+    }
+
     //endregion
     //region column()
 
@@ -280,6 +289,18 @@ public function testGroupByOnFlatThrows(string $class): void
         $class::new(['a', 'b'])->groupBy('g');
     }
 
+    #[DataProvider('modeProvider')]
+    public function testGroupBySkipsScalarRows(string $class): void
+    {
+        // One array value makes the array "nested"; scalar rows have no fields to group by
+        $sa = $class::new([['g' => 'a', 'v' => 1], 'scalar', ['g' => 'a', 'v' => 2]]);
+
+        [$result, $output] = $this->captureOutput(fn() => $sa->groupBy('g'));
+
+        $this->assertSame(['a' => [['g' => 'a', 'v' => 1], ['g' => 'a', 'v' => 2]]], $result->toArray());
+        $this->assertSame('', $output);
+    }
+
     //endregion
     //region keys() / values()