From 3e272c8fb283e73be4aace45f8bc4ad2a8a72a7f Mon Sep 17 00:00:00 2001 From: Jacob Bell <228905018+OS-jacobbell@users.noreply.github.com> Date: Fri, 17 Apr 2026 13:43:50 -0600 Subject: [PATCH 1/3] chore(ci): use latest stencil react-output-target in nightly --- .../build-core-stencil-prerelease/action.yml | 16 ++++++++++++---- .../workflows/actions/build-react/action.yml | 16 +++++++--------- .github/workflows/stencil-nightly.yml | 17 ++++++++++++++--- 3 files changed, 33 insertions(+), 16 deletions(-) diff --git a/.github/workflows/actions/build-core-stencil-prerelease/action.yml b/.github/workflows/actions/build-core-stencil-prerelease/action.yml index 913e8f494ff..570414a4bcf 100644 --- a/.github/workflows/actions/build-core-stencil-prerelease/action.yml +++ b/.github/workflows/actions/build-core-stencil-prerelease/action.yml @@ -1,10 +1,14 @@ name: 'Build Ionic Core with Stencil Prerelease' description: 'Build Ionic Core with a Prerelease Build of Stencil' inputs: - stencil-version: + stencil-core-version: description: 'The NPM tag of @stencil/core to install.' type: string required: true + stencil-react-output-target-version: + description: 'The NPM tag of @stencil/react-output-target to install.' + type: string + required: true runs: using: 'composite' steps: @@ -17,9 +21,13 @@ runs: run: npm ci working-directory: ./core shell: bash - - name: 📦 Install Stencil ${{ inputs.stencil-version }} + - name: 📦 Install Stencil Core ${{ inputs.stencil-core-version }} + working-directory: ./core + run: npm i @stencil/core@${{ inputs.stencil-core-version }} + shell: bash + - name: 📦 Install Stencil React Output Target ${{ inputs.stencil-react-output-target-version }} working-directory: ./core - run: npm i @stencil/core@${{ inputs.stencil-version }} + run: npm i @stencil/react-output-target@${{ inputs.stencil-react-output-target-version }} shell: bash - name: 🏗️ Build Core run: npm run build -- --ci --debug --verbose @@ -29,4 +37,4 @@ runs: with: name: ionic-core output: core/CoreBuild.zip - paths: core/dist core/components core/css core/hydrate core/loader core/src/components.d.ts core/package.json + paths: core/dist core/components core/css core/hydrate core/loader core/src/components.d.ts core/package.json packages/react/src/components/components.ts diff --git a/.github/workflows/actions/build-react/action.yml b/.github/workflows/actions/build-react/action.yml index 9b4a5995e9e..b1f403bc9df 100644 --- a/.github/workflows/actions/build-react/action.yml +++ b/.github/workflows/actions/build-react/action.yml @@ -31,16 +31,14 @@ runs: run: npm run test.spec shell: bash working-directory: ./packages/react - - name: Clean core package.json - run: git checkout ./package.json - shell: bash - working-directory: ./core - - name: 🔍 Check Diff - run: git diff --exit-code - shell: bash - working-directory: ./packages/react - uses: ./.github/workflows/actions/upload-archive with: name: ionic-react output: packages/react/ReactBuild.zip - paths: packages/react/dist packages/react/css + paths: packages/react/dist packages/react/css packages/react/package.json + - name: Clean package.json updates + run: git checkout ./core/package.json ./packages/react/package.json + shell: bash + - name: 🔍 Check Diff + run: git diff --exit-code + shell: bash diff --git a/.github/workflows/stencil-nightly.yml b/.github/workflows/stencil-nightly.yml index 3e8d714ccc1..0125db88881 100644 --- a/.github/workflows/stencil-nightly.yml +++ b/.github/workflows/stencil-nightly.yml @@ -9,11 +9,16 @@ on: - cron: '00 06 * * 1-5' workflow_dispatch: inputs: - npm_release_tag: + npm_release_tag_core: required: true type: string - description: What version should be pulled from NPM? + description: What stencil/core version should be pulled from NPM? default: nightly + npm_release_tag_react_output_target: + required: true + type: string + description: What stencil/react-output-target version should be pulled from NPM? + default: latest # When pushing a new commit we should # cancel the previous test run to not @@ -29,7 +34,9 @@ jobs: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - uses: ./.github/workflows/actions/build-core-stencil-prerelease with: - stencil-version: ${{ inputs.npm_release_tag || 'nightly' }} + stencil-core-version: ${{ inputs.npm_release_tag_core || 'nightly' }} + stencil-react-output-target-version: ${{ inputs.npm_release_tag_react_output_target || 'latest' }} + test-core-clean-build: needs: [build-core-with-stencil-nightly] @@ -173,6 +180,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + - name: Install Stencil React Output Target + working-directory: ./packages/react + run: npm i @stencil/react-output-target/${{ inputs.npm_release_tag_react_output_target }} + shell: bash - uses: ./.github/workflows/actions/build-react build-react-router: From 86bc69020d608e9cce73e6d4f26c2d3ea4fe9ead Mon Sep 17 00:00:00 2001 From: Jacob Bell <228905018+OS-jacobbell@users.noreply.github.com> Date: Fri, 17 Apr 2026 14:33:06 -0600 Subject: [PATCH 2/3] chore(ci): fix npm install and git checkout --- .github/workflows/actions/build-vue/action.yml | 4 +--- .github/workflows/actions/test-core-clean-build/action.yml | 3 +-- .github/workflows/stencil-nightly.yml | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/actions/build-vue/action.yml b/.github/workflows/actions/build-vue/action.yml index 170e889f968..bad5691dbbf 100644 --- a/.github/workflows/actions/build-vue/action.yml +++ b/.github/workflows/actions/build-vue/action.yml @@ -28,13 +28,11 @@ runs: shell: bash working-directory: ./packages/vue - name: Clean core package.json - run: git checkout ./package.json + run: git checkout ./core/package.json ./packages/react/package.json shell: bash - working-directory: ./core - name: 🔍 Check Diff run: git diff --exit-code shell: bash - working-directory: ./packages/vue - uses: ./.github/workflows/actions/upload-archive with: name: ionic-vue diff --git a/.github/workflows/actions/test-core-clean-build/action.yml b/.github/workflows/actions/test-core-clean-build/action.yml index 92e3fed394b..09849ef43c6 100644 --- a/.github/workflows/actions/test-core-clean-build/action.yml +++ b/.github/workflows/actions/test-core-clean-build/action.yml @@ -13,9 +13,8 @@ runs: path: ./core filename: CoreBuild.zip - name: Clean core package.json - run: git checkout ./package.json + run: git checkout ./core/package.json ./packages/react/package.json shell: bash - working-directory: ./core - name: 🔍 Check Diff run: | git diff --exit-code || { diff --git a/.github/workflows/stencil-nightly.yml b/.github/workflows/stencil-nightly.yml index 0125db88881..4d6b2cdfc99 100644 --- a/.github/workflows/stencil-nightly.yml +++ b/.github/workflows/stencil-nightly.yml @@ -182,7 +182,7 @@ jobs: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Install Stencil React Output Target working-directory: ./packages/react - run: npm i @stencil/react-output-target/${{ inputs.npm_release_tag_react_output_target }} + run: npm i @stencil/react-output-target@${{ inputs.npm_release_tag_react_output_target }} shell: bash - uses: ./.github/workflows/actions/build-react From d61f52aca83b1ca5381dc41b5746060f0b90026d Mon Sep 17 00:00:00 2001 From: Jacob Bell <228905018+OS-jacobbell@users.noreply.github.com> Date: Fri, 17 Apr 2026 15:26:43 -0600 Subject: [PATCH 3/3] chore(ci): run lint in packages/react --- .../actions/build-core-stencil-prerelease/action.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/actions/build-core-stencil-prerelease/action.yml b/.github/workflows/actions/build-core-stencil-prerelease/action.yml index 570414a4bcf..630a3b675bb 100644 --- a/.github/workflows/actions/build-core-stencil-prerelease/action.yml +++ b/.github/workflows/actions/build-core-stencil-prerelease/action.yml @@ -33,6 +33,10 @@ runs: run: npm run build -- --ci --debug --verbose working-directory: ./core shell: bash + - name: 🏗️ Lint + run: npm run lint + working-directory: ./packages/react + shell: bash - uses: ./.github/workflows/actions/upload-archive with: name: ionic-core