From 8125ddc0532280de7ecbf1e4c9f585bea0324e1c Mon Sep 17 00:00:00 2001 From: jrd Date: Sun, 2 Aug 2026 23:06:54 +0000 Subject: [PATCH 1/2] docs(JSON-RPC): fix connection example calling a non-existent method The "Connect to a JSON-RPC server" snippet called `jamulusserver/getServerInfo`, which the server does not implement (returns -32601 Method not found). It also skipped authentication, which every method requires. Use `jamulus/apiAuth` instead: it is a real method and the mandatory first call on any connection. Co-Authored-By: Claude Opus 5 --- docs/JSON-RPC.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/JSON-RPC.md b/docs/JSON-RPC.md index e9111187f4..a4c941489a 100644 --- a/docs/JSON-RPC.md +++ b/docs/JSON-RPC.md @@ -41,7 +41,7 @@ This snippet uses [jayson](https://www.npmjs.com/package/jayson) to connect usin const jayson = require("jayson/promise"); const client = new jayson.client.tcp({ host: "127.0.0.1", port: 22100 }); -client.request('jamulusserver/getServerInfo', {}) +client.request('jamulus/apiAuth', { secret: "...the secret from the file in --jsonrpcsecretfile..." }) .then(console.log) .catch(console.error) ``` From 0eab6475f08c143e4d7eac623a8ca515039808a9 Mon Sep 17 00:00:00 2001 From: jrd Date: Sat, 8 Aug 2026 05:02:25 +0000 Subject: [PATCH 2/2] docs(JSON-RPC): make the same fix in the generator JSON-RPC.md is generated by tools/generate_json_rpc_docs.py (see the file header); editing only the output would be undone on the next regeneration. Running the generator now reproduces the committed JSON-RPC.md exactly. Co-Authored-By: Claude Fable 5 --- tools/generate_json_rpc_docs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/generate_json_rpc_docs.py b/tools/generate_json_rpc_docs.py index 0495c4b1af..b3aac24f72 100755 --- a/tools/generate_json_rpc_docs.py +++ b/tools/generate_json_rpc_docs.py @@ -270,7 +270,7 @@ def to_markdown(self): const jayson = require("jayson/promise"); const client = new jayson.client.tcp({ host: "127.0.0.1", port: 22100 }); -client.request('jamulusserver/getServerInfo', {}) +client.request('jamulus/apiAuth', { secret: "...the secret from the file in --jsonrpcsecretfile..." }) .then(console.log) .catch(console.error) ```